Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13] refact!: table removal #270

Merged
merged 90 commits into from
Aug 30, 2023
Merged

[13] refact!: table removal #270

merged 90 commits into from
Aug 30, 2023

Conversation

v-rocheleau
Copy link
Contributor

No description provided.

@v-rocheleau v-rocheleau marked this pull request as ready for review July 18, 2023 20:16
davidlougheed
davidlougheed reviewed Jul 19, 2023
View reviewed changes
src/components/datasets/DatasetDataTypes.js Outdated Show resolved Hide resolved
src/components/datasets/DatasetDataTypes.js Outdated Show resolved Hide resolved
src/components/datasets/datatype/DataTypeSummaryModal.js Outdated Show resolved Hide resolved
src/components/manager/projects/Project.js Outdated Show resolved Hide resolved
src/components/datasets/DatasetDataTypes.js Outdated Show resolved Hide resolved
src/modules/metadata/actions.js Outdated Show resolved Hide resolved
src/modules/metadata/actions.js Outdated Show resolved Hide resolved
src/modules/metadata/actions.js Outdated Show resolved Hide resolved
src/components/datasets/DatasetOverview.js Outdated Show resolved Hide resolved
src/components/manager/TableTreeSelect.js Outdated Show resolved Hide resolved
davidlougheed
davidlougheed requested changes Aug 16, 2023
View reviewed changes
src/components/datasets/DatasetDataTypes.js Outdated Show resolved Hide resolved
src/components/datasets/DatasetDataTypes.js Outdated Show resolved Hide resolved
src/components/datasets/DatasetDataTypes.js Show resolved Hide resolved
src/components/datasets/DatasetFormModal.js Outdated Show resolved Hide resolved
@davidlougheed davidlougheed self-requested a review August 28, 2023 19:57
v-rocheleau and others added 25 commits August 28, 2023 17:09
@v-rocheleau
remove faulty disable condition
2e67a36
@v-rocheleau
fix datasets reducer
e953069
@v-rocheleau
datasets data-types actions refactor
b7d5cc6
@v-rocheleau
lint
407eba9
@v-rocheleau
simplify fetchUserDependentData
80c856c
@v-rocheleau
lint
cb48d88
@v-rocheleau
Merge pull request #283 from bento-platform/features/table-removal-da…
3bc70bd 
…taset-level-disable

feat: in search, disable data types with 0-count at dataset level
@davidlougheed
refact: memoization in DatasetSelectionModal
6c0bfe6
@davidlougheed
refact: use state datasetsByID in ManagerIngestionContent
e0fe672
@davidlougheed
refact: component for showing project/dataset title in ManagerIngesti…
c0843f0 
…onContent

lint: memoize style
@davidlougheed
lint: rm commented-out code
eacd94b
@davidlougheed
refact: use redux datasetsByID in ExplorerDatasetSearch
cd3b92a
@davidlougheed
lint: rm useless fragments in DataTypeSummaryModal
fab56e4
@davidlougheed
lint: DataTypeExplorationModal
1b26068
@davidlougheed
lint: DataTypeSelect
0f6539d
@davidlougheed
Merge remote-tracking branch 'origin/master' into features/table-removal
9b0b54a 
# Conflicts:
#	src/components/explorer/ExplorerDatasetSearch.js
@davidlougheed
chore: tweak rendering + memoize biosample/experiment/individual tabl…
44dc496 
…e cell components
@davidlougheed
lint
25c0b1b
@davidlougheed
refact: move search results table to folder
68d785e
@davidlougheed
refact: memoization + lint for ExplorerSearchResultsTable
9f6bee7
@davidlougheed
fix: rm alternateIds from biosample ID render
89beb20
@davidlougheed
fix: wrong props in explorersearchresultstable
4eb8926
@davidlougheed
feat: biosample links with hashes from individuals + biosamples page
30b3f70
@davidlougheed
feat: individual id link component used in biosamples table too
d2fc2fe
@davidlougheed
Merge pull request #284 from bento-platform/feat/explorer/table-impro…
af90344 
…vements

feat(explorer): table render/linking improvements
davidlougheed
davidlougheed approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets get this thing merged

@v-rocheleau v-rocheleau merged commit f9eb659 into master Aug 30, 2023
3 checks passed
@davidlougheed davidlougheed deleted the features/table-removal branch August 30, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidlougheed davidlougheed davidlougheed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v-rocheleau @davidlougheed @noctillion