Skip to content

Commit

Permalink
Merge pull request #34 from bento-platform/chore/updates
Browse files Browse the repository at this point in the history
chore: update base image, dependencies, codecov
  • Loading branch information
davidlougheed authored Feb 12, 2024
2 parents 88294b0 + 99a0078 commit 6b5ba8c
Show file tree
Hide file tree
Showing 5 changed files with 360 additions and 336 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: [ "3.10", "3.11" ]
python-version: [ "3.10", "3.12" ]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
Expand All @@ -23,4 +23,6 @@ jobs:
- name: Test
run: python -m poetry run pytest -svv --cov=bento_service_registry --cov-branch
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v4
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
FROM ghcr.io/bento-platform/bento_base_image:python-debian-2024.01.01
FROM ghcr.io/bento-platform/bento_base_image:python-debian-2024.02.01

# Use uvicorn (instead of hypercorn) in production since I've found
# multiple benchmarks showing it to be faster - David L
RUN pip install --no-cache-dir "uvicorn[standard]==0.27.0"
RUN pip install --no-cache-dir "uvicorn[standard]==0.27.1"

# Backwards-compatible with old BentoV2 container layout
WORKDIR /service-registry
Expand Down
4 changes: 2 additions & 2 deletions dev.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
FROM ghcr.io/bento-platform/bento_base_image:python-debian-2024.01.01
FROM ghcr.io/bento-platform/bento_base_image:python-debian-2024.02.01

RUN pip install --no-cache-dir "uvicorn[standard]==0.27.0"
RUN pip install --no-cache-dir "uvicorn[standard]==0.27.1"

# Backwards-compatible with old BentoV2 container layout
WORKDIR /service-registry
Expand Down
Loading

0 comments on commit 6b5ba8c

Please sign in to comment.