Skip to content
This repository has been archived by the owner on Feb 27, 2024. It is now read-only.

Fix Dom-Reconciliation w/ Headers #14

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

brackenish
Copy link

Right now, since columnData.headerRenderer is called directly, React isn't necessarily seeing that the underlying components have changed. This converts the rendering of headers to component syntax to fix errors related to this.

@brackenish
Copy link
Author

@benox3 so, interesting thing to discuss here. in order to get this to work, I need to change the type signature of header renderer to be an element, not a node. however, this breaks types if a function were to return a string/number directly. is that a concern here?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant