ensure to pass hostname when doing an SSL request

[benoitc]

fix #759

[luismiramirez]

I get a connection error now:

Validating Push API key: [hackney trace 80 <0.94.0> 2025:02:27 10:31:10 4677] request 
   Content: [{module,hackney},
             {line,313},
             {method,post},
             {url,
                 {hackney_url,hackney_ssl,https,<<"push.appsignal.com">>,
                     <<"/1/auth?name=&hostname=&api_key=1234&environment=dev">>,
                     <<"/1/auth">>,
                     <<"name=&hostname=&api_key=1234&environment=dev">>,
                     <<>>,"push.appsignal.com",443,<<>>,<<>>}},
             {headers,
                 [{<<"Content-Type">>,<<"application/json; charset=UTF-8">>}]},
             {body,<<>>},
             {options,
                 [{ssl_options,
                      [{verify,verify_peer},
                       {cacertfile,
                           <<"/Users/luismiramirez/code/handshake/_build/dev/lib/appsignal/priv/cacert.pem">>},
                       {versions,['tlsv1.3','tlsv1.2']},
                       {customize_hostname_check,
                           [{match_fun,#Fun<public_key.6.112534691>}]}]},
                  {pool,appsignal_transmitter}]}]
[hackney trace 60 <0.94.0> 2025:02:27 10:31:10 4678] request without proxy 
   Content: [{module,hackney},{line,686}]
[hackney trace 60 <0.94.0> 2025:02:27 10:31:10 4679] connect 
   Content: [{module,hackney_connect},
             {line,32},
             {transport,hackney_ssl},
             {host,"push.appsignal.com"},
             {port,443},
             {dynamic,true}]
[hackney trace 80 <0.94.0> 2025:02:27 10:31:10 4685] no socket in the pool 
   Content: [{module,hackney_pool},{line,88},{pool,appsignal_transmitter}]
[hackney trace 80 <0.94.0> 2025:02:27 10:31:10 4686] connect error 
   Content: [{module,hackney_connect},{line,238}]

Validating failed, reason:

  :checkout_failure

[benoitc]

@luismiramirez can you paste me the whole hackney line you're doing ?

[luismiramirez]

Sure, it'd be something like:

:hackney.request(
      :post,
      "https://push.appsignal.com/auth?name=&hostname=&api_key=1234&environment=dev",
      [{"Content-Type", "application/json; charset=UTF-8"}],
      "",
      pool: :appsignal_transmitter,
      ssl_options: [
        verify: :verify_peer,
        cacertfile:
          "/Users/luismiramirez/code/handshake/_build/dev/lib/appsignal/priv/cacert.pem",
        versions: ["tlsv1.3", "tlsv1.2"],
        customize_hostname_check: [
          match_fun: :public_key.pkix_verify_hostname_match_fun(:https)
        ]
      ]
    )

[benoitc]

Thanks! Can you try without setting any ssl_options and let me know about the result? That would be very helpful.

…

On 3 Mar 2025, at 16:16, Luismi Ramírez ***@***.***> wrote: luismiramirez left a comment (benoitc/hackney#763) Sure, it'd be something like: :hackney.request( :post, "https://push.appsignal.com/auth?name=&hostname=&api_key=1234&environment=dev", [{"Content-Type", "application/json; charset=UTF-8"}], "", pool: :appsignal_transmitter, ssl_options: [ verify: :verify_peer, cacertfile: "/Users/luismiramirez/code/handshake/_build/dev/lib/appsignal/priv/cacert.pem", versions: ["tlsv1.3", "tlsv1.2"], customize_hostname_check: [ match_fun: :public_key.pkix_verify_hostname_match_fun(:https) ] ] ) — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread. <#763 (comment)> <https://github.com/notifications/unsubscribe-auth/AAADRITRVN2KRBRCEY4KT732SRW4ZAVCNFSM6AAAAABX5ZTUBKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOJUG4ZTIMJXGA> luismiramirez left a comment (benoitc/hackney#763) <#763 (comment)> Sure, it'd be something like: :hackney.request( :post, "https://push.appsignal.com/auth?name=&hostname=&api_key=1234&environment=dev", [{"Content-Type", "application/json; charset=UTF-8"}], "", pool: :appsignal_transmitter, ssl_options: [ verify: :verify_peer, cacertfile: "/Users/luismiramirez/code/handshake/_build/dev/lib/appsignal/priv/cacert.pem", versions: ["tlsv1.3", "tlsv1.2"], customize_hostname_check: [ match_fun: :public_key.pkix_verify_hostname_match_fun(:https) ] ] ) — Reply to this email directly, view it on GitHub <#763 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAADRITRVN2KRBRCEY4KT732SRW4ZAVCNFSM6AAAAABX5ZTUBKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOJUG4ZTIMJXGA>. You are receiving this because you authored the thread.

[luismiramirez]

Here it is without ssl_options

Validating Push API key: [hackney trace 80 <0.94.0> 2025:03:04 08:01:20 4339] request 
   Content: [{module,hackney},
             {line,313},
             {method,post},
             {url,{hackney_url,hackney_ssl,https,<<"push.appsignal.com">>,
                               <<"/1/auth?name=&hostname=&api_key=1234=dev">>,
                               <<"/1/auth">>,
                               <<"name=&hostname=&api_key=1234&environment=dev">>,
                               <<>>,"push.appsignal.com",443,<<>>,<<>>}},
             {headers,[{<<"Content-Type">>,
                        <<"application/json; charset=UTF-8">>}]},
             {body,<<>>},
             {options,[{pool,appsignal_transmitter}]}]
[hackney trace 60 <0.94.0> 2025:03:04 08:01:20 4341] request without proxy 
   Content: [{module,hackney},{line,686}]
[hackney trace 60 <0.94.0> 2025:03:04 08:01:20 4342] connect 
   Content: [{module,hackney_connect},
             {line,32},
             {transport,hackney_ssl},
             {host,"push.appsignal.com"},
             {port,443},
             {dynamic,true}]

Validating failed, reason:

  :checkout_failure

[hackney trace 80 <0.94.0> 2025:03:04 08:01:20 4372] no socket in the pool 
   Content: [{module,hackney_pool},{line,88},{pool,appsignal_transmitter}]