bump hackney to latest stable 0.14.3 .

- fix memory leaks
- fix socket lingering

rebar.config

@@ -12,5 +12,5 @@
 
     %% hackney for doing HTTP requests
     {hackney, ".*", {git, "git://github.com/benoitc/hackney.git",
-                     {tag, "0.13.0"}}}
+                     {tag, "0.14.3"}}}
 ]}.

rebar_dev.config

@@ -21,7 +21,7 @@
 
     %% hackney for doing HTTP requests
     {hackney, ".*", {git, "git://github.com/benoitc/hackney.git",
-                     {tag, "0.13.0"}}},
+                     {tag, "0.14.3"}}},
 
     {edown, ".*",
          {git, "git://github.com/esl/edown.git", "HEAD"}}

src/couchbeam.erl

@@ -315,8 +315,7 @@ all_dbs(#server{url=ServerUrl, options=Opts}) ->
 db_exists(#server{url=ServerUrl, options=Opts}, DbName) ->
     Url = hackney_url:make_url(ServerUrl, dbname(DbName), []),
     case couchbeam_httpc:db_request(head, Url, [], <<>>, Opts, [200]) of
-        {ok, _, _, Ref} ->
-            hackney:skip_body(Ref),
+        {ok, 200, _}->
             true;
         _Error ->
             false
@@ -441,9 +440,7 @@ doc_exists(#db{server=Server, options=Opts}=Db, DocId) ->
     DocId1 = couchbeam_util:encode_docid(DocId),
     Url = hackney_url:make_url(server_url(Server), doc_url(Db, DocId1), []),
     case couchbeam_httpc:db_request(head, Url, [], <<>>, Opts, [200]) of
-        {ok, _, _, Ref} ->
-            hackney:skip_body(Ref),
-            true;
+        {ok, _, _} -> true;
         _Error -> false
     end.
 
@@ -765,7 +762,7 @@ lookup_doc_rev(#db{server=Server, options=Opts}=Db, DocId, Params) ->
     Url = hackney_url:make_url(server_url(Server), doc_url(Db, DocId1),
                                Params),
     case couchbeam_httpc:db_request(head, Url, [], <<>>, Opts, [200]) of
-        {ok, _, Headers, _} ->
+        {ok, _, Headers} ->
             HeadersDict = hackney_headers:new(Headers),
             re:replace(hackney_headers:get_value(<<"etag">>, HeadersDict),
                 <<"\"">>, <<>>, [global, {return, binary}]);

src/couchbeam_view.erl

@@ -458,14 +458,20 @@ fold_view_results(Ref, Fun, Acc) ->
 collect_view_results(Ref, Acc) ->
     receive
         {Ref, done} ->
+            io:format("got done ~n", []),
             Rows = lists:reverse(Acc),
             {ok, Rows};
         {Ref, {row, Row}} ->
+            io:format("got row ~p~n", [Row]),
             collect_view_results(Ref, [Row|Acc]);
         {Ref, {error, Error}} ->
             %% in case we got some results
             Rows = lists:reverse(Acc),
-            {error, Error, Rows}
+            {error, Error, Rows};
+        Else ->
+            io:format("got unknown message ~p~n", [Else])
+    after 10000 ->
+              {error, timeout}
     end.
 
 view_request(#db{options=Opts}, Url, Args) ->

src/couchbeam_view_stream.erl

@@ -86,37 +86,44 @@ init_stream(Parent, Owner, StreamRef, {_Db, _Url, _Args}=Req,
 do_init_stream({#db{options=Opts}, Url, Args}, #state{mref=MRef}=State) ->
     %% we are doing the request asynchronously
     FinalOpts = [{async, once} | Opts],
-    {ok, Ref} = case Args#view_query_args.method of
+    Reply = case Args#view_query_args.method of
         get ->
             hackney:request(get, Url, [], <<>>, FinalOpts);
         post ->
             Body = couchbeam_ejson:encode({[{<<"keys">>,
                                              Args#view_query_args.keys}]}),
             hackney:request(post, Url, [], Body, FinalOpts)
     end,
-    receive
-        {'DOWN', MRef, _, _, _} ->
-            %% parent exited there is no need to continue
-            exit(normal);
-        {hackney_response, Ref, {status, 200, _}} ->
-            #state{parent=Parent,
-                   owner=Owner,
-                   ref=StreamRef,
-                   async=Async} = State,
-
-            DecoderFun = jsx:decoder(?MODULE, [Parent, Owner, StreamRef,
-                                               MRef, Ref, Async],
-                                     [stream]),
-            {ok, State#state{client_ref=Ref,
-                             decoder=DecoderFun}};
-
-        {hackney_response, Ref, {error, Reason}} ->
-            exit(Reason)
-    after ?TIMEOUT ->
-            exit(timeout)
+
+    case Reply of
+        {ok, Ref} ->
+            receive
+                {'DOWN', MRef, _, _, _} ->
+                    %% parent exited there is no need to continue
+                    exit(normal);
+                {hackney_response, Ref, {status, 200, _}} ->
+                    #state{parent=Parent,
+                           owner=Owner,
+                           ref=StreamRef,
+                           async=Async} = State,
+
+                    DecoderFun = jsx:decoder(?MODULE, [Parent, Owner,
+                                                       StreamRef, MRef, Ref,
+                                                       Async], [stream]),
+                    {ok, State#state{client_ref=Ref,
+                                     decoder=DecoderFun}};
+
+                {hackney_response, Ref, {error, Reason}} ->
+                    exit(Reason)
+            after ?TIMEOUT ->
+                    exit(timeout)
+            end;
+        Error ->
+            {error, Error}
     end.
 
 
+
 loop(#state{owner=Owner,
             ref=StreamRef,
             mref=MRef,
@@ -147,7 +154,7 @@ decode_data(Data, #state{owner=Owner,
                          ref=StreamRef,
                          client_ref=ClientRef,
                          decoder=DecodeFun}=State) ->
-    try 
+    try
         {incomplete, DecodeFun2} = DecodeFun(Data),
         try DecodeFun2(end_stream) of done ->
             %% stop the request
@@ -343,7 +350,6 @@ send_row(Row, #viewst{owner=Owner, ref=Ref}=ViewSt) ->
     Owner ! {Ref, {row, Row}},
     maybe_continue_decoding(ViewSt).
 
-
 %% eventually wait for the next call from the parent
 maybe_continue_decoding(#viewst{parent=Parent,
                                 owner=Owner,