Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.rst #275

Merged
merged 4 commits into from
May 22, 2024
Merged

Update README.rst #275

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6eaa4a1
Update README.rst
satcomjimmy May 16, 2024
e42f7ee
Update README.rst
satcomjimmy May 16, 2024
1ec9132
Update README.rst
satcomjimmy May 16, 2024
062e6ed
Update README.rst
satcomjimmy May 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,8 @@ main application URL conf as well as your chosen invitation backend URLs:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from django.urls import path, include

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @satcomjimmy I did a bad job describing what I was suggesting. I think it's a great idea to still include this line!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think @bennylope?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I likely have some more edits to suggest in the future, so I can add it back on a future PR

urlpatterns = [
...
url(r'^accounts/', include('organizations.urls')),
url(r'^invitations/', include(invitation_backend().get_urls())),
path('accounts/', include('organizations.urls')),
path('invitations/', include(invitation_backend().get_urls())),
]

This is the simplest way of using the library, but it's far from the only
Expand Down
Loading