CMake: Support building as shared library / QML module. #35
Conversation
|
@benlau Hi! I am currently packaging this project for Debian as it is needed to bring to Ubuntu Touch apps to Debian: telePORTS (a Telegram chat client) and Dekko2 (an email client). For this, I need to be able to build quickflux as a shared library / QML module (rather then linking it into the application statically at build-time). In this PR find a patch, that should achieve this (note: I haven't tested it yet, will do so soon). |
CMakeLists.txt
Outdated
| @@ -6,8 +6,15 @@ | |||
| cmake_minimum_required(VERSION 3.0.0) | |||
| project(quickflux VERSION 1.1.3) | |||
|
|
|||
| option(quickflux_INSTALL "Enable the installation of targets." ON) | |||
| option(quickflux_BUILD_SHARED "Build as shared library" OFF) | |||
There was a problem hiding this comment.
Maybe this should define BUILD_SHARED_LIBS, the CMake-integrated way of controlling this? https://cmake.org/cmake/help/latest/variable/BUILD_SHARED_LIBS.html
CMakeLists.txt
Outdated
|
|
||
| if(quickflux_BUILD_SHARED) | ||
| SET(SOVERSION_MAJOR 1) | ||
| SET(SOVERSION_MINOR 0) |
There was a problem hiding this comment.
Project version above is 1.1.3, where does the 0 here come from?
CMakeLists.txt
Outdated
| ) | ||
| add_library(QuickFlux::quickflux ALIAS quickflux) | ||
| if(quickflux_BUILD_SHARED) | ||
| add_library(quickflux SHARED |
There was a problem hiding this comment.
See question about BUILD_SHARED_LIBS above, that would alleviate the need for duplicating all of this.
There was a problem hiding this comment.
@OPNA2608 You are a much better CMake dev than I am. Could you come up with a follow-up PR bringing this more into harmony?
There was a problem hiding this comment.
Submitted as a PR to this branch: sunweaver#1
- Use
BUILD_SHARED_LIBSfor determining static/dynamic library - Directly use
PROJECT_VERSIONfor library versioning - Configure
qmldirwith@ONLY
(option name mangled so GitHub doesn't ping a random person)
sunweaver
force-pushed
the
pr/build-shared-lib
branch
from
d41bfa9
to
a29c4d0
Compare
No description provided.