Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude inactive accounts in lookup cache #114

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/aws_sso_lib/lookup.py
Original file line number Diff line number Diff line change
Expand Up @@ -557,6 +557,9 @@ def lookup_accounts_for_ou(session, ou, *, recursive, refresh=False, cache=None,
else:
LOGGER.debug(f"Loaded cached accounts for {ou_type} {ou}: (empty list)")
for account in cache[ou_accounts_key]:
if exclude_inactive_accts and account["Status"] != "ACTIVE":
LOGGER.debug(f"Skipping account {account['Id']}: {account['Status']}")
continue
if org_mgmt_acct and account["Id"] == org_mgmt_acct:
continue
yield account
Expand Down