Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifing archiva version - for 2.2.1 #9

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Modifing archiva version - for 2.2.1 #9

wants to merge 4 commits into from

Conversation

iHealthGroup
Copy link

  1. Modifing archiva version - for 2.2.1
  2. Command for build image and start container

@benjamin-heasly
Copy link
Owner

Hi,

Thank you for the version bump to 2.2.1. Those two commits look good to me.

I'm a little confused by the third commit, which changes the README. It looks like the build and run instructions use a tag name and port number which are specific for your organization. Is that right?

I would like to keep the README generic, and focused on the public image which is hosted at DockerHub -- ninjaben/archiva-docker.

Would you consider reverting the last commit so that we can merge just the version change? Then, if you like, I'd be happy to discuss changes to the README in a separate PR.

Thank you very much!

@iHealthGroup
Copy link
Author

Hi,

Thank you for the considerations. You are right. I should not have submitted the changes to the README. You can discard the changes in the README. What's the best way to do this?

Best regards!

This reverts commit 8ef620b.

Unecessary doc in README file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants