Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark square #171

Open
wants to merge 5 commits into
base: github
Choose a base branch
from
Open

Mark square #171

wants to merge 5 commits into from

Conversation

ukscid
Copy link
Contributor

@ukscid ukscid commented Feb 10, 2024

A mark "square" is defined but not implemented : "variable Type {full|square|arrow|circle|disk|tux}"

This implements drawSquare and use it for %csl, set it for standard in comment editor. This mark shows a rectangle.
Advantage: the mark from pgn data and a mark from colorsquare (used by gloss of danger and suggested move) can displayed together.
The size is a little bit smaller than a square to show also the rectangle from "highlight last move".
The function of the mark "full" is not touched.

@benini
Copy link
Owner

benini commented Feb 28, 2024

Are there other software that mark squares with a rectangle? How do they handle %csl?"

@ukscid
Copy link
Contributor Author

ukscid commented Feb 29, 2024

@benini
Copy link
Owner

benini commented Feb 29, 2024

Chessbase use rounded rectangles: https://help.chessbase.com/CBase/17/Eng/graphic_commentary.htm?zoom_highlightsub=mark%2Bsquare

Interesting.
What about lichess and chess.com?

@ukscid
Copy link
Contributor Author

ukscid commented Mar 1, 2024

Lichess uses circles: https://lichess.org/study/jTcC0b7Q/rVqUvSQd
chess.com: https://www.chess.com/analysis?tab=analysis : Ignores the %csl and show nothing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants