Formalize linetable parsing and propagate out-of-bounds errors #755
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've noticed a transient issue where
py-spy
will abort due to unmet assumptions about the contents ofco_linetable
(for example we've seen[231]
, which doesn't even satisfy the internal specification). To address this, I've patched theco_linetable
parsing to propagate out-of-bounds errors so that the samples are simply ignored (and a warning is raised).This change is not as minimal as it could be, for example it reorders a couple lines in
python_interpreters.rs
for clarity. If that's a problem, I'd be happy to go back and pare down such changes.Taking a glance, I would guess this is the root cause for #735 and #569, although I have no explanation for why the
co_linetable
's appear invalid.