cleanup

bendyworks · Mar 31, 2020 · 860b6fb · 860b6fb
1 parent 12fdd46
commit 860b6fb
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 12 deletions.
diff --git a/README.md b/README.md
@@ -9,15 +9,18 @@ Machine Learning Plugin for Capacitor. Currently offered implementations include
 
 ## Compatibility Chart
 
-| Feature  | ios | android |
-| ------------- | ------------- | ------------ |
-| ML Framework  | CoreML Vision  | MLKIt Vision |
-| Text Detection with Still Images | Yes | Yes |
-| Detects lines of text | Yes | Yes |
-| Bounding Coordinates for Text | Yes | Yes |
-| Image Orientation | Yes (Up, Left, Right, Down) | Yes (Up, Left, Right, Down) |
-| Skewed Text| Yes | No |
-| Angled (Rotated <~ 45deg) Text | Yes | Yes |
+| Feature                          | ios                         | android                     |
+| -------------------------------- | --------------------------- | --------------------------- |
+| ML Framework                     | CoreML Vision               | Firebase MLKit              |
+| Text Detection with Still Images | Yes                         | Yes                         |
+| Detects lines of text            | Yes                         | Yes                         |
+| Bounding Coordinates for Text    | Yes                         | Yes                         |
+| Image Orientation                | Yes (Up, Left, Right, Down) | Yes (Up, Left, Right, Down) |
+| Skewed Text                      | Yes                         | Unreliable                  |
+| Rotated Text (<~ 45deg)          | Yes                         | Yes (but with noise)        |
+| On-Device                        | Yes                         | Yes                         |
+| SDK/ios Version                  | ios 13.0 or newer           | Targets API level >= 16<br>Uses Gradle >= 4.1<br>com.android.tools.build:gradle >= v3.2.1<br>compileSdkVersion >= 28 |
+| | | |
 
 
 ## Installation

diff --git a/examples/text-detection/ImageReader/ios/App/App.xcodeproj/project.pbxproj b/examples/text-detection/ImageReader/ios/App/App.xcodeproj/project.pbxproj
@@ -345,7 +345,7 @@
 			buildSettings = {
 				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
 				CODE_SIGN_STYLE = Automatic;
-				DEVELOPMENT_TEAM = SL5E64FK4A;
+				DEVELOPMENT_TEAM = "";
 				INFOPLIST_FILE = App/Info.plist;
 				IPHONEOS_DEPLOYMENT_TARGET = 11.0;
 				LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
@@ -364,7 +364,7 @@
 			buildSettings = {
 				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
 				CODE_SIGN_STYLE = Automatic;
-				DEVELOPMENT_TEAM = SL5E64FK4A;
+				DEVELOPMENT_TEAM = "";
 				INFOPLIST_FILE = App/Info.plist;
 				IPHONEOS_DEPLOYMENT_TARGET = 11.0;
 				LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";

diff --git a/ios/Plugin/Plugin.swift b/ios/Plugin/Plugin.swift
@@ -19,7 +19,6 @@ public class CapML: CAPPlugin {
             call.reject("file does not contain an image")
             return
         }
-
         TextDetector(call: call, image: image).detectText()
     }
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -19,7 +19,6 @@ public class CapML: CAPPlugin { @@
                 call.reject("file does not contain an image")
                 return
             }
             TextDetector(call: call, image: image).detectText()
         }
     }