Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sheath heat flux diagnostics #67

Draft
wants to merge 24 commits into
base: master
Choose a base branch
from
Draft

Add sheath heat flux diagnostics #67

wants to merge 24 commits into from

Conversation

mikekryjak
Copy link
Collaborator

@mikekryjak mikekryjak commented Oct 10, 2022 •
edited
Loading

  • Add diagnostics for sheath heat flux in sheath_boundary_simple
  • Perform full particle and energy balance on 1D-recycling
  • Add documentation on sheath_boundary_simple and sheath_boundary

@mikekryjak mikekryjak changed the title Add diagnose option Add sheath heat flux diagnostics Oct 10, 2022
@mikekryjak
Copy link
Collaborator Author

Now works and saves the following variables:

  • phi_sheath: phi for use in the boundary code
  • J_sheath: combined ion current for use in the boundary code
  • Ee_sheath: additional electron heat flux to achieve gamma_e
  • E_sheath: additional ion heat flux to achieve gamma_i

@bendudson let me know if this is a good idea or if it's too confusing. Maybe E_sheath should have the total heat flux so it's less confusing? And I wonder if including J and phi will make it confusing when currents are included.

@mikekryjak mikekryjak marked this pull request as ready for review October 17, 2022 08:58
@mikekryjak mikekryjak marked this pull request as draft December 7, 2022 16:39
@mikekryjak mikekryjak added enhancement New feature or request post-processing Improvements in what diagnostics are saved to file labels Apr 14, 2023
@mikekryjak
Copy link
Collaborator Author

This one needs an update as there are now some sheath diagnostics present

mikekryjak and others added 16 commits July 30, 2024 17:35
@mikekryjak
Merge with master
33b22fb
@mikekryjak
Simplify diagnostic recording
a56000e
@mikekryjak
Correct volume calculation
259cd30
@mikekryjak
Reverse incorrect volume change, make diagnostics source
fee5286 
dx*dy drops out due to form of equation above... I don't like it because it's unclear.

Diagnostic variable now in W/m2 instead of W.
@mikekryjak
Add sheath particle flux diagnostic, improve code clarity
978c9f9 
- Explicitly defined da and dv to ensure validity when guard dx/dz != last dx/dz and to improve code clarity
- This is now in line with neutral_boundary.cxx
- Particle and heat flux diagnostics match post-processing calcs
@mikekryjak
Merge branch 'master' into sheath-diagnostics
92fd8f1
@mikekryjak
Merge branch 'fix-impurity-rad-sign' into sheath-diagnostics
61f27b0
@mikekryjak
Correct sheath heat flux formula
e784228 
- Was assuming gamma is total
@mikekryjak
Add conduction divergence term to diagnostics
4bf3c1a
@mikekryjak
Improve diagnostic name
8b7967d 
- Species name at the end to allow easy splitting
- "div" can be a prefix for other divergence terms we save
@mikekryjak
Merge branch 'conduction-heatflux-diag' into sheath-diagnostics
98f82cb
@bendudson
Add flow_ylow diagnostics
02bca79 
Parallel advection and parallel heat conduction are now included in
the flow_ylow diagnostics. Advection of parallel kinetic energy
(momentum equation) is not yet tracked.
@bendudson
evolve_pressure: add numerical_viscous_heating term
e371fc7 
Intended to compensate for dissipation in the momentum advection term.
Needs checking: Doesn't make much difference.
@mikekryjak
Fix formula for total sheath heat flux
207dd51
@mikekryjak
Merge remote-tracking branch 'origin/parallel-sheath' into sheath-dia…
74a3b2d 
…gnostics
@mikekryjak
Add separate diagnostic for just conduction
fae713c 
- EnergyFlow remains total energy flow
@mikekryjak mikekryjak mentioned this pull request Aug 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request post-processing Improvements in what diagnostics are saved to file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikekryjak @bendudson