suggested fix for #124 #168
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
admwx7
requested changes
Sep 14, 2017
| @@ -652,7 +669,27 @@ | |||
| }, | |||
| _withinValidRange: function(date) { | |||
| if (this._isValidDate(date)) { | |||
| return (!this.minDate || date >= this.minDate) && (!this.maxDate || date <= this.maxDate); | |||
| return (!this.minDate || date >= this.minDate) && (!this.maxDate || date <= this.maxDate); | |||
| @@ -289,6 +289,22 @@ | |||
| value: null | |||
| }, | |||
| /** | |||
| *Array of selectable dates | |||
| * (whitelist) | |||
| */ | |||
There was a problem hiding this comment.
Add Format must be String YYYY-MM-DD here as well as on invalidDates so it's documented for people using this element stand-alone.
| return false; | ||
| }, | ||
|
|
||
| _confirmsToWhiteAndBlacklist: function(date){ |
There was a problem hiding this comment.
Collapse these 3 into:
/**
* Ensures that our date is valid and passes both white and black list checks.
* @protected
*
* @param {Date} date
* @return {Boolean}
*/
_checkWhiteBlackLists: function(date) {
return this._isValidDate(date) &&
(this.validDates || []).indexOf(this.dateFormat(date,'YYYY-MM-DD')) < 0 &&
(this.invalidDates || []).indexOf(this.dateFormat(date,'YYYY-MM-DD')) < 0;
}
So we aren't biting the cost of always checking both lists, and checking for a valid date 3 times when we don't have to.
|
Fixes #113 |
|
You're completely right, will change tonight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Ben, stumbled across this fr and thought what the hell - any remarks, would be happy to help some more?
#124