Merge pull request #2 from benceszasz/bszasz-connectfollow

CareLink reCAPTCHA login using WebView

.github/ISSUE_TEMPLATE/bug-report.md

@@ -1,17 +1,19 @@
 ---
-name: "\U0001F41BBug report\U0001F41B"
-about: Create a report to help us improve things
-label: bug
+name: "Please do not open an issue unless asked to do so by a developer in a discussion (see below)"
+about: Please include a link to the discussion in the first post.
+label: status-triage
 ---
 
-### If you need support for xDrip, PLEASE DO NOT FILE A TICKET HERE
-- For support, please post a question to the xDripG5 group at Facebook (https://www.facebook.com/groups/xDripG5) or visit the Gitter room at https://gitter.im/jamorham/xDrip-plus.
+### Please don't open an issue if you haven't already consulted with the developers
+- Please go back and use Discussions (on the previous page) to present your case if you haven't already.
+- If you have consulted with the developers and were asked to open an issue, please proceed.
 - Please also search the existing issues for similar problems before opening a new one.
 - Please do not prefix you issue title with BUG: or LIBRE: for instance. The issue maintainer will tag every issue with appropriate labels.
 - Add screenshots only if necessary, e.g. write the version number instead of adding a screenshot of the system status page.
 
 ### Subject of the issue
-A clear and concise description of what the bug is.
+Link to the discussion thread:  
+A clear and concise description of what the bug or request is.
 Example: The BG graph shows negative data points between 3 and 5 am, which is incorrect and can only be an artefact.
 
 ### Your environment

.github/ISSUE_TEMPLATE/config.yml

@@ -1,8 +1,5 @@
 blank_issues_enabled: false
 contact_links:
-  - name: xDrip Community Support at Facebook
-    url: https://www.facebook.com/groups/xDripG5
-    about: If you're a xDrip user and have trouble with the app or any connected device, please post questions here. We don't have the resources to answer support questions posted here as tickets.
-  - name: xDrip Community Support at Gitter
-    url: https://gitter.im/jamorham/xDrip-plus
-    about: If you're a xDrip user and have trouble with the app or any connected device, please post questions here. We don't have the resources to answer support questions posted here as tickets.
+  - name: xDrip Discussions
+    url: https://github.com/NightscoutFoundation/xDrip/discussions
+    about: Please use "Discussions" (link on the right) to communicate with developers and/or other users (bug report, feature request, or questions).

.github/workflows/unit_test.yml

@@ -11,17 +11,19 @@ jobs:
 
     runs-on: ubuntu-latest
 
+    strategy:
+      matrix:
+        java-version: [ 11 ]
+
     steps:
     - uses: actions/checkout@v2
-    - name: set up JDK 1.8
-      uses: actions/setup-java@v1
+    - uses: actions/setup-java@v2
+      with:
+        java-version: ${{ matrix.java-version }}
+        distribution: adopt
+    - name: Run unit tests and assemble APKs
+      uses: gradle/gradle-build-action@v2
       with:
-        java-version: 1.8
-    - name: Grant execute permission for gradlew
-      run: chmod +x gradlew
-    - name: Run Unit Tests
-      run: ./gradlew test
-    - name: Run Compile Tests
-      run: ./gradlew assembleRelease
+        arguments: assembleProdRelease testProdReleaseUnitTest
     - name: Check Output
       run: bash ./etc/CheckBuild/check-release.sh test

CONTRIBUTING.md

@@ -1,18 +1,27 @@
 # Reporting Issues with xDrip
 
-### Please try to provide as much information as possible when raising an issue:
+Before opening an issue, please communicate with us by posting in "Discussions":  
+https://github.com/NightscoutFoundation/xDrip/discussions
+We will encourage you to open an issue if it is not already known and there is no work-around.  
 
-* If it is a bug, please try to explain how to reproduce it, roughly which settings you are using, what you are seeing or not seeing. Screenshots welcomed.
-* If it relates to a new feature, please explain the rationale for the feature, use cases and detail your suggestion.
+### Please provide as much information as possible when communicating your concerns with us:
 
+* If it is a bug, please try to explain how to reproduce it, roughly which settings you are using, what you are seeing or not seeing. Screenshots welcomed.
+* If it relates to a new feature, please explain the rationale for the feature, use cases and detail your suggestion.  
 
 # Contributing patches to xDrip
 
 ### Do you have an idea for a feature or enhancement or bugfix for Nightscout xDrip?
 
 Patches are welcomed! To ensure the best all round results they need be a good fit with the project roadmap, the ecosystem of users and respect overall project stability and good practice.
 
-The best way to get patches accepted is to discuss your ideas with project maintainers prior to implementation and discuss how to structure things so that they can fit well within the project and also the rationale for the change.
+The best way to get patches accepted is to discuss your ideas with project maintainers using [Discussions](https://github.com/NightscoutFoundation/xDrip/discussions) prior to implementation and discuss how to structure things so that they can fit well within the project and also the rationale for the change.
+
+#### Copyright of submitted contributions
+
+Any submitted patches and pull requests must either be the original work of the submitter or be available under a suitable open source license which is compatible with inclusion in a GPL licensed project.
+
+This also applies to graphics, sounds or other binary file content. Ideally these should be either the original work of the submitter or be in the public domain. They should not contain trademarks.
 
 #### Project reviewers are likely to use criteria similar to that outlined below:
 
@@ -28,10 +37,11 @@ Make sure any pull request has a clear title and a good description.
 
 Try not to bundle different patches together and keep the change set to the minimum required. Even unrelated changes to whitespace have to be reviewed in case a random keystroke broke something. The less lines there are to review, the clearer the patch will be to any reviewer.
 
-Maintainers are not always immediately aware of pull request submissions, which is another reason why it helps to have discussed your work prior to submission. Feel free to ask about the progress of processing your PR as maintainers may not realise a PR is awaiting action.
-
-Nightscout xDrip is maintained by volunteers.
-
+Maintainers are not always immediately aware of pull request submissions, which is another reason why it helps to have discussed your work prior to submission. Feel free to ask about the progress of processing your PR as maintainers may not realise a PR is awaiting action.  
 
+# Translations
 
+Please use [xDrip+ on Crowdin](https://crowdin.com/project/xdrip) if you have any questions about translations, or like to add a language or contribute to an existing language. 
 
+___
+Nightscout xDrip is maintained by volunteers.

Documentation/libre-fix-bt-connection-issues.md

@@ -1,15 +1,12 @@
-
-
 # If you have a lot of missed readings:
 
 You can try other settings:
-
 * Solution 0:
-  * Make sure xdrip is not being killed by OS
-   * set xdrip into the "ignored battery optimization" list
+  * Make sure xDrip is not being killed by OS
+   * set xDrip into the "ignored battery optimization" list
    * If you use a Huawei phone:
      * lock app
-     * allow xdrip to be launched at start
+     * allow xDrip to be launched at start
 * Solution 1:
   * ```Trust Auto Connect``` to ON
   * ```close GATT on disconnect``` to OFF
@@ -22,12 +19,15 @@ You can try other settings:
   * Enable or disable ```Always discover services```
 
 # On each try, make sure to:
+
 * reset your device
 * reboot phone
+* use the latest xDrip app
+
+# Provide more info so that we can support you:
 
-# Provide more info that we can support you
 * solution 1:
-  * Enable enginering mode
+  * Enable engineering mode
     * Look here: https://github.com/NightscoutFoundation/xDrip/wiki/Engineering-Mode
   * Make a screenshot from system status / BT devices
 * solution 2:

Documentation/technical/Kotlin_Policy.md

@@ -0,0 +1,9 @@
+### Kotlin Policy
+
+xDrip supports both Java and Kotlin source files.
+
+New class files in Java or Kotlin are accepted but there is no intention to convert existing Java files to Kotlin.
+
+Kotlin classes should be mindful to maintain as much java compatibility as possible where they may need to interact with existing classes.
+
+Overhead in terms of additional libraries and any performance related issues (such as threading and component lifecycle) should be carefully monitored.

README.md

@@ -50,7 +50,7 @@ Your data is yours and can be exported in many different ways. xDrip also interc
 * More Nightscout and APS integration
 
 ## Collaboration
-We are very happy if people want to collaborate with this project. Please contact us if you want to get involved and study the [collaboration guidelines](CONTRIBUTING.md) before submitting any patches or pull requests.
+We are very happy if people want to collaborate with this project. Please contact us at [Discussions](https://github.com/NightscoutFoundation/xDrip/discussions) if you want to get involved and study the [collaboration guidelines](CONTRIBUTING.md) before submitting any patches or pull requests.
 
 ## Thanks
 None of this would be possible without all the hard work of the xDrip and Nightscout communities who have developed such excellent software and allowed us to build upon it.