Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle lock matching better and clean up #22

Merged
merged 3 commits into from
Mar 1, 2024
Merged

Handle lock matching better and clean up #22

merged 3 commits into from
Mar 1, 2024

Conversation

Fran-Rg
Copy link
Contributor

@Fran-Rg Fran-Rg commented Feb 28, 2024

Resolves #20
Resolves #21
Closes #23

* Issues: 21 + 20
@ben-z
Copy link
Owner

ben-z commented Feb 28, 2024

Thanks for the PR! Any ideas on how to fix the CI failures?

@Fran-Rg
Copy link
Contributor Author

Fran-Rg commented Feb 29, 2024

I'm currently testing further the PR as there were some issues.

Looks like the actions are locked and require approval to run: https://github.com/ben-z/gh-action-mutex/actions/runs/8095240799

@ben-z
Copy link
Owner

ben-z commented Mar 1, 2024

Approved, seems to be the same issue: https://github.com/ben-z/gh-action-mutex/actions/runs/8095240799

@ben-z
Copy link
Owner

ben-z commented Mar 1, 2024

Strange, runs fine in #23

Perhaps it's a permission issue with forks (#15).

@ben-z
Copy link
Owner

ben-z commented Mar 1, 2024

LGTM! Thanks for the contribution. Merging.

@ben-z ben-z changed the title Fix mutex (#20 + #21) Handle lock matching better and clean up Mar 1, 2024
@ben-z ben-z merged commit 5baf892 into ben-z:main Mar 1, 2024
4 of 8 checks passed
@ben-z
Copy link
Owner

ben-z commented Mar 1, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace awk commands for more specific commands Replace should check for exact line from beginning to end
2 participants