Skip to content

Improve buffers sizes and buffer size computation #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sschaetz
Copy link

Description

When using fast-cpp-csv-parser in a project with -Wall -Werror I am hitting two issues that this PR works around:

  • incorrect size computation in strncpy
  • buffer sizes too small for the long paths I see when working with bazel

@ben-strasser
Copy link
Owner

The larger error message numbers are now on master.

@ben-strasser
Copy link
Owner

The strncpy change does not actually change anything as a null-char is added on the next line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants