Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example of making README.md more easy to apply directly from within dom0 #48

Closed
wants to merge 1 commit into from

Conversation

tlaurion
Copy link

Add QUBE=name_of_qube so the script can be run as is from dom0 changing first line and then applying next commands as is.

Add QUBE=name_of_qube so the script can be run as is from dom0 changing first line and then applying next commands as is.
@tlaurion
Copy link
Author

tlaurion commented Apr 20, 2024

@ben-grande just an example. Don't use this unsigned commit, just a suggestion.

@ben-grande
Copy link
Owner

Just ran the action to test if the action itself is working, don't worry.

I am not satisfied with the current state of the client installation in all the formulas, it is difficult to make it clear to the user that they need to modify a variable. Using a literal shell variable helps users that understand the shell to run the commands quicker, but does not help users that don't understand what they should do.

Ideally, a concise explanation: substitute the value of the variable QUBE to the name of the qube you want to install the client configuration.

I also don't want to repeat this same sentence on all readmes, maybe put it in a document in the docs directory and link on the readme to that doc section/header.

Anything that requires the user to modify the command-line instead of copy paste can cause problems. See this example, it is the installation phase, the user can't copy from DomU to Dom0 easily, they had to substitute the variable values and their modification was incorrect. Is this lack of shell knowledge? Yes, maybe it is not fixable on the shell side, maybe only a GUI that can allow a user to select the qubes graphically of which qube should have the configuration applied is the solution.

@ben-grande
Copy link
Owner

Closing per previous comment.

@ben-grande ben-grande closed this Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants