Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qvm-wireguard qubename user input #2

Closed
wants to merge 2 commits into from
Closed

Conversation

n1ete
Copy link

@n1ete n1ete commented Jan 27, 2024

just a tiny change to make qvm-wireguard work with multiple wireguard qubes

@ben-grande
Copy link
Owner

Hello, thanks for the contribution.

However, it already works with multiple qubes. The expansion ${1:-"default_value"} is a shell expansion, if $1 is not set or empty, use default_value instead, else use $1. I should have done a usage message to explain that the default qube is the one provided by qusal (sys-wireguard), but you can use with any other wireguard qube.

Read GNU Bash Shell Parameter Expansion for more information, although it applies to Bourne Shell, Ksh and Zsh and many others, so it is widely supported, not only Bash.

If you understood the above and wants to contribute a usage message, I can accept that, use git-init-qrexec usage message as template.

@ben-grande
Copy link
Owner

Note: Your commits do not follow the format required for contribution, if you run gitlint and pre-commit locally you will see, for now, the linting is not working for PRs.

@n1ete
Copy link
Author

n1ete commented Jan 28, 2024

Thanks for the explanation, learned something new! I made a sys-mitmproxy saltstate will need to lint and cleanup the scripts, but i will do a new pull request and close this one for now then... :)

@n1ete n1ete closed this Jan 28, 2024
@ben-grande
Copy link
Owner

I made a sys-mitmproxy saltstate will need to lint and cleanup the scripts, but i will do a new pull request and close this one for now then... :)

If you plan to contribute a new formula such as sys-mitmproxy, please open an issue first to discuss it, this makes sure you don't waste time in case it is not accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants