-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CI #4
Improve CI #4
Conversation
Use really the latest Ubuntu and retrieve Clang from LLVM apt.
Build with libc++, add 17 and 19 to CI
Workaround for gtest issues with libc++ from clang-17. Run as root
@@ -3,7 +3,7 @@ include_guard(GLOBAL) | |||
set(CMAKE_CXX_STANDARD 23) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remind me -- is there something here that requires 23, or could it be 20?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll check. I believe at one point I was looking at deducing this
but then didn't.
@@ -1,76 +1,121 @@ | |||
name: ci | |||
name: Test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm no expert on these github workflows now - @bretbrownjr any comments? Specifically I'm wondering about non-Linux platforms. Also, @steve-downey did this come from our template or do we need to update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@steve-downey , is there a way to run these flows on local environment? e.g. git API to span a Docker for every job, but on my local setup. I am just curious if I am doing a change, if I can run all jobs on my MAC OS / Ubuntu.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not found a way to simulate any of this locally. I've ended up enabling actions on PRs and repeated force-pushes to a branch to trigger a run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a bunch of it from bemanproject/exemplar#6. I also have some possible updates to deal with Node version warnings over here: https://github.com/steve-downey/lambda-fun/pull/2/files
Merging so as to base further work on working CI |
Improve the CI workflow, building with clang 17, 18, and 19, against libc++, and with GCC 13 and 14 using Ubuntu 24.04 as the base OS.