-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweaks for alpha release #23
Merged
neatudarius
merged 20 commits into
bemanproject:main
from
neatudarius:tweaks-in-docs-for-alpha
Jun 27, 2024
Merged
Tweaks for alpha release #23
neatudarius
merged 20 commits into
bemanproject:main
from
neatudarius:tweaks-in-docs-for-alpha
Jun 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For every complex problem there is an answer that is clear, simple, and
wrong. --- H.L Mencken
This is probably not the right place to sort out license details.
I agree that we need to make the licensing as single as possible, but no
simpler.
…On Mon, Jun 24, 2024, 19:27 Darius Neațu ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In README.md
<#23 (comment)>
:
>
**Implements**:
* [Give *std::optional* Range Support (P3168R1)](https://wg21.link/P3168R1)
* [`std::optional<T&>` (P2988R5)](https://wg21.link/P2988R5)
## License
-Source is licensed with the Apache 2.0 license with LLVM exceptions
+Source, documentation and associated papers are licensed with the Apache 2.0 license with LLVM exceptions.
I received this suggestion from @camio <https://github.com/camio> . Let's
discuss here. I don't have any preferences.
—
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVNZ5WOGF7HG6AOJ5KAVH3ZJC2PNAVCNFSM6AAAAABJ2WNPKWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMZXGAZTIMZVHE>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
23f3282
to
e6ae8a7
Compare
94e808b
to
c79c241
Compare
b89c91b
to
fc95223
Compare
neatudarius
commented
Jun 27, 2024
neatudarius
commented
Jun 27, 2024
neatudarius
commented
Jun 27, 2024
neatudarius
commented
Jun 27, 2024
steve-downey
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
And hopefully to others tonight!
a4ea801
to
a8d9929
Compare
a8d9929
to
c0a9d02
Compare
c5d5899
to
a883a1a
Compare
a883a1a
to
c5ee5ec
Compare
Link to #14 - as we introduce P3168R2 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweaks for alpha release (Saint Louis demo)
Related issues: #12 #11 #16
Updates:
C++: clang-format
,Shell: shellcheck
,MD: markdownlint
,YAML: yamlfmt
,Cmake: cmake-format
scripts/README.md
for scripts and linters.