Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BEMAN_STANDARD: REPOSITORY.CODEOWNERS #99

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
+1 −1
Open

Update BEMAN_STANDARD: REPOSITORY.CODEOWNERS #99

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c1948d7
Update BEMAN_STANDARD: REPOSITORY.CODEOWNERSS
neatudarius Feb 28, 2025
50537a4
Update BEMAN_STANDARD.md
neatudarius Feb 28, 2025
2e45332
Update BEMAN_STANDARD.md
neatudarius Feb 28, 2025
36fd1a0
Update BEMAN_STANDARD.md
neatudarius Feb 28, 2025
10daec5
Update BEMAN_STANDARD.md
neatudarius Feb 28, 2025
6a98af0
Update BEMAN_STANDARD.md
neatudarius Feb 28, 2025
7f53d28
Update docs/BEMAN_STANDARD.md
neatudarius Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/BEMAN_STANDARD.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ Examples: A `beman.smart_pointer` library's repository should be named `smart_po
Bad examples: `smartpointer` or `optional26`.

**[REPOSITORY.CODEOWNERS]** REQUIREMENT: There must be a `.github/CODEOWNERS` file
with a relevant set of codeowners.
with a relevant set of codeowners, starting with the local codeowners and ending with [@bemanproject/principal-codeowners](https://github.com/orgs/bemanproject/teams/principal-codeowners) (to speed up code review). Please check [exemplar: CODEOWNERS](https://github.com/bemanproject/exemplar/blob/main/.github/CODEOWNERS).
Copy link
Member

@camio camio Mar 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
with a relevant set of codeowners, starting with the local codeowners and ending with [@bemanproject/principal-codeowners](https://github.com/orgs/bemanproject/teams/principal-codeowners) (to speed up code review). Please check [exemplar: CODEOWNERS](https://github.com/bemanproject/exemplar/blob/main/.github/CODEOWNERS).
with a relevant set of codeowners, starting with the local codeowners and ending with [@bemanproject/core-reviewers](https://github.com/orgs/bemanproject/teams/core-reviewers) (a group of Beman regulars who offered to help generally with code reviews). Please check [exemplar: CODEOWNERS](https://github.com/bemanproject/exemplar/blob/main/.github/CODEOWNERS).


**[REPOSITORY.DISALLOW_GIT_SUBMODULES]** RECOMMENDATION: The repository should not use git submodules. Check `CMAKE.USE_FIND_PACKAGE` for alternatives.

Expand Down