Add typescript for naming.presets #323
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarastqt
force-pushed
the
yarastqt.issue-322
branch
from
0876c9f to
025a0c9
Compare
|
Добавилд сборку для Так же возможно вынести куда-то в общее место секцию со скриптами |
yarastqt
force-pushed
the
yarastqt.issue-322
branch
from
025a0c9 to
9679fe8
Compare
awinogradov
approved these changes
Aug 15, 2018
packages/naming.presets/package.json
Outdated
| "files": [ | ||
| "*.js", | ||
| "index.d.ts" | ||
| ], | ||
| "scripts": { | ||
| "build:cjs": "tsc --module commonjs --outDir lib", | ||
| "build:es": "tsc --module es2015 --outDir es", | ||
| "build:typings": "tsc --emitDeclarationOnly --declaration --declarationDir typings", |
There was a problem hiding this comment.
А зачем тайпинги отдельно собирать? Можно же за один прихлоп.
There was a problem hiding this comment.
Если в конфиге указать, то он будет ругаться на то, что у нас уже есть сгенерированные файлы, можно конечно в 1 билд скрипт это добавить типо tsc --module commonjs --outDir lib --declaration --declarationDir typings
Кажется норм, уберу этот скрипт
yarastqt
force-pushed
the
yarastqt.issue-322
branch
2 times, most recently
from
8d64b43 to
36f1949
Compare
yarastqt
force-pushed
the
yarastqt.issue-322
branch
from
36f1949 to
eb7bf91
Compare
yarastqt
force-pushed
the
yarastqt.issue-322
branch
from
eb7bf91 to
40b0e1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve for this #322
TODO: