Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Refactoring ENB config #1349

Closed
wants to merge 17 commits into from
Closed

[WIP] Refactoring ENB config #1349

wants to merge 17 commits into from

Conversation

blond
Copy link
Member

@blond blond commented Feb 10, 2015

Resolved #1345

[techs.bem.bemjsonToBemdecl, {
target : '.tmp.bemdecl.js'
}],
[techs.bem.deps, {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tech.levels({ levels : levels }),
tech.bemjsonToBemdecl('.tmp.bemdecl.js'), // sugar for target

etc. ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reopened old issue in this topic. I propose to continue the discussion there.


// JavaScript Files
[techs.bem.depsByTechToBemdecl, {
target : '.tmp.required-js.bemdecl.js',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why required?

@arikon
Copy link
Member

arikon commented Feb 12, 2015

@andrewblond There should be an introductory message in the description of pull request to get the idea of the changes.

@aristov
Copy link
Contributor

aristov commented Feb 24, 2015

@andrewblond what is the status of this PR?

@narqo
Copy link
Member

narqo commented Mar 19, 2015

@andrewblond any progress here?

@blond
Copy link
Member Author

blond commented Mar 20, 2015

@aristov, @narqo decided that divide this PR a few PRs: #1345

@aristov aristov changed the title Refactoring ENB config (WIP) [WIP] Refactoring ENB config Apr 2, 2015
@tadatuta tadatuta closed this Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants