Add alias @ for symbol start entity #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyar
force-pushed
the
add_alias_start_entity
branch
2 times, most recently
from
d0e932b to
fc0c09d
Compare
Fix error: npm is known not to run on Node.js v0.12.18 You'll need to upgrade to a newer version in order to use this version of npm. Supported versions are 4, 6, 7, 8, 9. You can find the
ilyar
force-pushed
the
add_alias_start_entity
branch
from
fc0c09d to
a7fbdcf
Compare
belozer
reviewed
Mar 26, 2018
| @@ -22,6 +22,14 @@ function buildSelector (ctx, mod) { | |||
| } | |||
|
|
|||
| export default postcss.plugin('pobem', () => (css) => { | |||
| css.walkAtRules(/block|elem|mod/, function (rule) { | |||
There was a problem hiding this comment.
@ilyar может стоит объединить это с обходом на 33 строке?. Зачем 2 раза делать практически аналогичные операции?
There was a problem hiding this comment.
Это не возможно т.к. walkAtRules обходит rule типа atrule, walkRules обходит rule типа rule, возможно это получится объединить если использовать walk
https://t.me/bem_ru/24592
@belozer почему возникает желание объединить?
There was a problem hiding this comment.
Думаю будет верно подумать в сторону выделить процесс разбора в отдельный метод.
There was a problem hiding this comment.
@belozer а что думаешь о предложении?
There was a problem hiding this comment.
Скорее всего будет bem-scope стиль. Наиболее близкий к ванильному css
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6