-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: materi WebApi Fetch #393
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Terimakasih sudah mau berkontribusi ke repositori javascript, mungkin ada beberapa hal yang harus di ubah sebelum PR ini di merge.
Sebelumnya commit pertama itu prefixnya add
yang seharusnya feat
. Di toleransi, tapi PR selanjutnya di usahakan pake feat
.
Kemudian dokumentasi ada beberapa saran yang ditambahkan, tetapi kalau bisa penjelasannya dikembangkan lagi, supaya orang yang baru belajar lebih paham akan penggunaan fetch ini.
Jangan lupa, kalo markdown pake
docs:
prefixnya.
Terimakasih!
Help bang @slowy07, codacy in progress terus badgenya |
passed no issue @reacto11mecha on |
Punten @adikurniawanid, gimana statusnya? Kalo belum ada update 2 hari lagi, PR ini bakalan di tutup |
Co-authored-by: Ezra Khairan Permana <[email protected]>
codacy check success #393, @reacto11mecha |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, terima kasih atas kontribusinya @adikurniawanid
Closes
Deskripsi (Description)
Contributor Requirements (Syarat Kontributor)
Environment
saya menggunakan (im used):
os
=linux / windows
Testing