Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: materi WebApi Fetch #393

Merged
merged 3 commits into from
Oct 16, 2023
Merged

feat: materi WebApi Fetch #393

merged 3 commits into from
Oct 16, 2023

Conversation

adikurniawanid
Copy link
Contributor

Closes

Deskripsi (Description)

  • saya menambahkan algoritma terbaru
  • saya memperbaiki algoritma yang sudah ada
  • saya menambahkan materi/sub materi belajar
  • saya memperbaiki materi/sub materi belajar
  • saya menambah dokumentasi
  • saya memperbaiki dokumentasi

Contributor Requirements (Syarat Kontributor)

  • saya sudah membaca (i have read) CONTRIBUTING dan sudah menyetujui semua
  • saya telah menambahkan docstring yang memberikan penjelasan maksud dari kode yang saya buat
  • saya menggunakan bahasa indonesia untuk memberikan penjelasan dari kode yang saya buat

Environment

saya menggunakan (im used):

  • os = linux / windows

Testing

  • doctesting js
  • lint testing eslint

@reacto11mecha reacto11mecha changed the title add: materi WebApi Fetch feat: materi WebApi Fetch Oct 6, 2023
Copy link
Member

@reacto11mecha reacto11mecha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terimakasih sudah mau berkontribusi ke repositori javascript, mungkin ada beberapa hal yang harus di ubah sebelum PR ini di merge.

Sebelumnya commit pertama itu prefixnya add yang seharusnya feat. Di toleransi, tapi PR selanjutnya di usahakan pake feat.

Kemudian dokumentasi ada beberapa saran yang ditambahkan, tetapi kalau bisa penjelasannya dikembangkan lagi, supaya orang yang baru belajar lebih paham akan penggunaan fetch ini.

Jangan lupa, kalo markdown pake docs: prefixnya.

Terimakasih!

learn/WebApi/fetch/README.md Outdated Show resolved Hide resolved
@reacto11mecha
Copy link
Member

Help bang @slowy07, codacy in progress terus badgenya

@reacto11mecha reacto11mecha requested a review from a team October 6, 2023 13:55
@slowy07
Copy link
Member

slowy07 commented Oct 11, 2023

passed no issue @reacto11mecha on codacy

@reacto11mecha
Copy link
Member

Punten @adikurniawanid, gimana statusnya? Kalo belum ada update 2 hari lagi, PR ini bakalan di tutup

Co-authored-by: Ezra Khairan Permana <[email protected]>
@slowy07
Copy link
Member

slowy07 commented Oct 14, 2023

codacy check success #393, @reacto11mecha

Copy link
Member

@reacto11mecha reacto11mecha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@slowy07 slowy07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, terima kasih atas kontribusinya @adikurniawanid

@mergify mergify bot merged commit e847057 into bellshade:main Oct 16, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants