Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ubuntu-latest to the matrix of test runners #181

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pjrobertson
Copy link
Collaborator

@pjrobertson pjrobertson commented Jan 21, 2025

tests on ubuntu-latest are currently failing, due to the issue in oscrypto: wbond/oscrypto#78 (comment)

Not sure if we want to merge this in, or wait for a solution before we merge

@msramalho
Copy link
Contributor

both https://github.com/wbond/certvalidator
and https://github.com/wbond/oscrypto
seem unmaintained.

the source dependency issue is in certvalidator that installs oscrypto (where the issue is)

alledgedly, this commit (not published to pypi) wbond/oscrypto@d5f3437 solves the issue (not personally verified)

can we fix the oscrypto version to that one even if it is installed as a dependency? that would be a quick fix


alternative is to find another way to achieve the same as certvalidator is currently doing, that may be a more involved task so I'd put behind the major modularization work we are doing at the moment.

@msramalho
Copy link
Contributor

also I'd not merge this PR until we can make sure the test suite will be working

@pjrobertson
Copy link
Collaborator Author

Sorry, I missed this yesterday. Changes look good, but is this perhaps an opportunity to do away with oscrypto (certvalidator). You said this also fixes the boto3 issue? I checked boto3 and oscrypto isn't a dependency on it.

In my 'remove dependencies' PR I mentioned that the timestamping_enricher has another old module asn1crypto. Perhaps a TODO is to rewrite timestamping_enricher to remove asn1crypto and certvalidator (and subsequently oscrypto). Thoughts? Shall we open an issue on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants