-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sphinx documentation and publish to RTD. #177
Conversation
Once we get the .readthedocs.yaml into main we can watch future builds on RTD. |
@pjrobertson most of those things were me lazily copying my instructions from different setups - apologies! I will update the original description to fix those, and indeed docs/_make and docs/source/autobuild should be in .gitignore (I will do that in a min) and add a section to the README for it. The Config docs were created by me running a hacky local script as mostly they're in the return statements rather than set as properties so I don't know if they can be pulled into the documentation via autoapi! If they do stay in a similar implementation we can tidy up that script and add it into the doc builds, but I think let's leave the automation out until then. However if there's something incorrect/ misleading I can manually edit that document too! |
…e and do a bit more tidying,
Just one small comment on the 'Configs' section in the 'Configuration' file (can we also rename 'Configs' to something more intuitive)? And then the removal of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff!
docs/source/configs.rst
Outdated
@@ -0,0 +1,741 @@ | |||
Configs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How were these .rst files created? Were they generated automatically, or by hand?
If automatically, perhaps we shouldn't include them in the repo, but should auto-generate them every time we build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it's just this configs.rst file that includes the specific configurations that could be auto-generated. Perhaps something for the future, once we've cleaned up our project structure (and it's easier to get the info directly from the manifest.py or argparse info?)
Configs | ||
------- | ||
|
||
This section of the documentation will show the custom configurations for the individual steps of the tool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this section should be renamed/removed, now that the 'configs' aren't included here?
Creating a fresh PR adding Sphinx documentation with RTD integration.
Summary
Run locally
poetry install
Then either manually:
open docs/_build/html/index.html
Or run autobuild to automatically detect changes when modifying the docs: