Implemented various things #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe toHaveOwnSlot could be added for the older behavior.
This fixes several edge cases when comparing strings which previously caused errors. Also added specs to test this new method. The existing spec for toBeString was also incorrect, the differing index is 8 not 9.
Added new methods toThrowWithMessage and toThrowWithType which are automatically called from toThrow based on the type of the expected parameter. They could also be called explicitly. Add associated specs as well.
|
Alright! I'm glad you found it interesting. Contribution well done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I've been learning Io and used jasmineio as a nice project to work on. I fixed some bugs I found in the toBeString matcher, made toHaveSlot work in what I think is the more "Io way" and I also implemented most of issue #3. I also did some whitespace cleanup, made a small spelling fix, and added myself to contributors.