Issue #173: More descriptive error message when creating/deploying an…

…other users app Signed-off-by: macdonst <[email protected]>
beginner-corp · Jan 16, 2024 · b3a45fc · b3a45fc
1 parent 10f3f1f
commit b3a45fc
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/commands/create/action.js b/src/commands/create/action.js
@@ -34,6 +34,7 @@ module.exports = async function action (params, utils) {
     }
     catch (err) {
       if (err.message === 'app_not_found') return Error(`No app found with app ID '${appID}'`)
+      if (err.message === 'unknown_error') return Error(`No app found with app ID '${appID}' or the user does not have permission to access the app.`)
       return
     }
     let envs = app.environments

diff --git a/src/commands/deploy/action.js b/src/commands/deploy/action.js
@@ -16,7 +16,14 @@ module.exports = async function action (params, utils) {
 
   // Go get the app (if we didn't just create one)
   if (!app) {
-    app = await client.find({ token, appID, _staging })
+    try {
+      app = await client.find({ token, appID, _staging })
+    }
+    catch (err) {
+      if (err.message === 'app_not_found') return Error(`No app found with app ID '${appID}'`)
+      if (err.message === 'unknown_error') return Error(`No app found with app ID '${appID}' or the user does not have permission to access the app.`)
+      return
+    }
   }
 
   let envs = app.environments