Updated the ActivityIndicator tests to also check for visibility when… #2838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… started and stopped Signed-off-by: Moises <[email protected]>
Signed-off-by: Moises <[email protected]>
Signed-off-by: Moises <[email protected]>
| @@ -5,3 +5,7 @@ | |||
|
|
|||
| class ActivityIndicatorProbe(SimpleProbe): | |||
| native_class = NSProgressIndicator | |||
|
|
|||
| @property | |||
| def is_hidden(self): | |||
There was a problem hiding this comment.
It would be worth being explicit that we're talking about the spinner visibility here. Depending on the implementation, it would be possible to have a widget that is "visible" in the sense of Toga's drawing instructions, but that that displays no content because the spinner is hidden. iOS got caught on this because spinner visibility and widget visibility are treated as the same thing; but that's no necessarily the same.
There's already a probe for evaluating visibility; spinner visibility isn't necessarily the same thing.
(edit) not sure what happened... this got submitted before I finished writing the comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… started and stopped
Updates the tests (based on #2829 review comments) to include visibility checks when testing the start/stop function of the ActivityIndicator widget
PR Checklist: