-
-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore iOS testing on current Xcode. #2497
Conversation
dd706c7
to
80d2e90
Compare
Still not working on the 20240415.6 image. |
I think the flaw is the error: "This backend doesn't use keyboard shortcuts" maybe we should remove keyboard shortcuts tests for iOS? |
I'm sorry? What has keyboard shortcuts got to do with this? This is 100% due to a regression in the behaviour of GitHub Actions CI. The tests did pass, and still do pass, as long as you're using a GitHub Actions image that hasn't been affected by the regression. |
It looks like the issue with the iOS simulator on GitHub Actions has been resolved... but has introduced new testing problems caused by the new default iOS version being iOS 18. |
Restores the use of the current Xcode and iOS simulator.
As part of the update, removes the use of the deprecated, and soon to be removed macOS-12 runner (using macOS-13, which is the last remaining x86_64 runner), and switches to macOS-latest for all other uses (which will be ARM64 going forward).
I also tried adding a
requires-python
declaration to testbed, since Briefcase now supports that feature; but that doesn't work because of the requirement for 3.12 for Wayland testing. However, I've updated contribution docs to highlight the general requirement; when we update the testbed to use more a more recent Pillow, we can switch to 3.12 across the board.Fixes #2476.
Fixes #2883.
PR Checklist: