Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore iOS testing on current Xcode. #2497

Merged
merged 16 commits into from
Oct 16, 2024
Merged

Conversation

freakboy3742
Copy link
Member

@freakboy3742 freakboy3742 commented Apr 12, 2024

Restores the use of the current Xcode and iOS simulator.

As part of the update, removes the use of the deprecated, and soon to be removed macOS-12 runner (using macOS-13, which is the last remaining x86_64 runner), and switches to macOS-latest for all other uses (which will be ARM64 going forward).

I also tried adding a requires-python declaration to testbed, since Briefcase now supports that feature; but that doesn't work because of the requirement for 3.12 for Wayland testing. However, I've updated contribution docs to highlight the general requirement; when we update the testbed to use more a more recent Pillow, we can switch to 3.12 across the board.

Fixes #2476.
Fixes #2883.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@freakboy3742 freakboy3742 marked this pull request as draft April 12, 2024 07:59
@freakboy3742 freakboy3742 marked this pull request as ready for review April 16, 2024 09:25
@freakboy3742
Copy link
Member Author

Still not working on the 20240415.6 image.

@randiaz95
Copy link

I think the flaw is the error: "This backend doesn't use keyboard shortcuts" maybe we should remove keyboard shortcuts tests for iOS?

@freakboy3742
Copy link
Member Author

I think the flaw is the error: "This backend doesn't use keyboard shortcuts" maybe we should remove keyboard shortcuts tests for iOS?

I'm sorry? What has keyboard shortcuts got to do with this?

This is 100% due to a regression in the behaviour of GitHub Actions CI. The tests did pass, and still do pass, as long as you're using a GitHub Actions image that hasn't been affected by the regression.

@freakboy3742
Copy link
Member Author

It looks like the issue with the iOS simulator on GitHub Actions has been resolved... but has introduced new testing problems caused by the new default iOS version being iOS 18.

@freakboy3742 freakboy3742 mentioned this pull request Aug 30, 2024
4 tasks
@mhsmith mhsmith merged commit 9261f89 into beeware:main Oct 16, 2024
40 checks passed
@freakboy3742 freakboy3742 deleted the ios-ci-fix branch October 16, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WinForms Testbed is unable to install Pillow dependency on python 3.12 CI crashing on iOS
3 participants