Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db: disable DQS on Python >= 3.12 #5235

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wisp3rwind
Copy link
Member

cf. #4709, let's see how badly this breaks CI

@wisp3rwind
Copy link
Member Author

ah, the Ubuntu LTS on CI has an ancient SQLite...

@sungo
Copy link

sungo commented May 8, 2024

to preface, I know precisely jack about python. I'm cutting and pasting to try and get my setup back online :) but after rolling a python 3.12 pyenv on freebsd, I tried this patch. it doesn't work for me unless those 0s are changed to 1s. so
conn.setconfig(sqlite3.SQLITE_DBCONFIG_DQS_DDL, 1) etc.

with that change, I seem to be up and running again on freebsd 13.1


edit: sorry. I've been a bit desperate here :) it occurs to me that of course you're actually trying to ferret out DQS problems in the build so you can fix them. however, the inverse of what you're trying to do fixed my setup on freebsd which has been frustrating the hell out of me the last little while :)

@arogl arogl mentioned this pull request May 8, 2024
1 task
@wisp3rwind
Copy link
Member Author

Oh, but if DQS can still be enabled at runtime, we could merge that change quickly as a workaround until we really remove all DQS usage (at least if the latter turns out to be a lot of work).

@wisp3rwind
Copy link
Member Author

Rebased on master to see what happens with #5447, but CI cannot properly test this these days: #5450

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants