Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extension issue in convert plugin when exporting a playlist #5203

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

pierreay
Copy link

Description

Fix extension substitution inside path of the exported playlist.

Before this, the exported playlist contained relative paths pointing to the
converted files BUT the extension were not substituted comparing to before and
the after the conversion. Therefore, running the playlist will fail for files
which have been converted and where extension have changed.

Example:

  1. Convert /path/to/library/artist.flac to /path/to/converted/artist.mp3 using the -m playlist.m3u command-line flag.
  2. Open the generated playlist, and find the incorrect path /path/to/converted/artist.flac inside.

To Do

  • Documentation
  • Changelog
  • Tests

@Serene-Arc Serene-Arc self-requested a review June 25, 2024 04:31
Copy link
Contributor

@Serene-Arc Serene-Arc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for the PR. I've left a comment or two. Would you also be able to add a test that fails under the old code and succeeds with the new?

beetsplug/convert.py Outdated Show resolved Hide resolved
@pierreay
Copy link
Author

Hi! Thanks for the PR. I've left a comment or two. Would you also be able to add a test that fails under the old code and succeeds with the new?

I'm not familiar with unit tests in Python, but since you ask, I will give a try!

Before this, the exported playlist contained relative paths pointing to the
converted files BUT the extension were not substituted comparing to before and
the after the conversion. Therefore, running the playlist will fail for files
which have been converted and where extension have changed.
@pierreay pierreay requested a review from Serene-Arc July 3, 2024 12:54
@pierreay
Copy link
Author

pierreay commented Jul 3, 2024

I added the appropriate test case! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants