-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Whisper worker as a service (Jobs don't work yet in airflow) #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brief explanation on service setup
…dengeluid/dane-whisper-asr-worker into 52-setup-service-decouple-from-dane
2 tasks
@Veldhoen ok I fixed this branch. It's merged with main and the basic wiring and start-up of the api works. From this basis, you should be able to wire up calls to whisper etc |
TODO: implement Willem's audio-extraction suggestions here too
greenw0lf
force-pushed
the
52-setup-service-decouple-from-dane
branch
from
September 26, 2024 08:26
d894219
to
6690ccd
Compare
They actually work! Only thing to track is memory usage
To keep in mind: memory might overflow! (when loading the model only once) This is to be monitored (to revert is quite easy) |
phew
remove whitespace on empty line
will need to refactor this, very hacky atm
Previous attempt did not work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #52