Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TornadoMath double version of trigonometric functions added #484

Merged
merged 2 commits into from
Jul 4, 2024
Merged

TornadoMath double version of trigonometric functions added #484

merged 2 commits into from
Jul 4, 2024

Conversation

jjfumero
Copy link
Member

@jjfumero jjfumero commented Jul 3, 2024 •
edited
Loading

Description

Some of the FP64 version of the trigonometric functions within the TornadoMath class were missing. Related issue #481

Problem description

n/ a,.

Backend/s tested

Mark the backends affected by this PR.

  • OpenCL
  • PTX
  • SPIRV

OS tested

Mark the OS where this PR is tested.

  • Linux
  • OSx
  • Windows

Did you check on FPGAs?

If it is applicable, check your changes on FPGAs.

  • Yes
  • No

How to test the new patch?

tornado-test -V -pk --fast uk.ac.manchester.tornado.unittests.math.TestTornadoMathCollection

@jjfumero jjfumero self-assigned this Jul 3, 2024
@jjfumero jjfumero added the API label Jul 3, 2024
@jjfumero
Copy link
Member Author

jjfumero commented Jul 3, 2024

On NVIDIA 1050;

Test: class uk.ac.manchester.tornado.unittests.math.TestTornadoMathCollection
	Running test: testTornadoMathSignumDouble ................  [PASS] 
	Running test: testTornadoMathSignumDoubleNaN ................  [OPENCL CONFIGURATION UNSUPPORTED] 
	Running test: testTornadoMathSignumFloatNaN ................  [OPENCL CONFIGURATION UNSUPPORTED] 
	Running test: testTornadoMathCos         ................  [PASS] 
	Running test: testTornadoMathCosPI       ................  [PASS] 
	Running test: testTornadoMathCosPIDouble ................  [PASS] 
	Running test: testTornadoMathSinPI       ................  [PASS] 
	Running test: testTornadoMathSinPIDouble ................  [PASS] 
	Running test: testTornadoMathSignumFloat ................  [PASS] 
	Running test: testTornadoMathSin         ................  [PASS] 
	Running test: testTornadoMathAtan        ................  [PASS] 
	Running test: testTornadoMathAtanDouble  ................  [PASS] 
	Running test: testTornadoMathTan         ................  [PASS] 
	Running test: testTornadoMathTanDouble   ................  [PASS] 
	Running test: testTornadoMathTanh        ................  [PASS] 
	Running test: testTornadoMathTanhDouble  ................  [PASS] 
	Running test: testTornadoMathMin         ................  [PASS] 
	Running test: testTornadoMathMax         ................  [PASS] 
	Running test: testTornadoMathSqrt        ................  [PASS] 
	Running test: testTornadoMathExpDouble   ................  [PASS] 
	Running test: testTornadoMathExpFloat    ................  [PASS] 
	Running test: testTornadoMathClamp       ................  [PASS] 
	Running test: testTornadoMathFract       ................  [PASS] 
	Running test: testTornadoMathLog2        ................  [PASS] 
	Running test: testTornadoMathLogDouble   ................  [PASS] 
	Running test: testTornadoMathLogFloat    ................  [PASS] 
	Running test: testTornadoMathPI          ................  [PASS] 
	Running test: testMathFloor              ................  [PASS] 
	Running test: testMathClamp              ................  [PASS] 
	Running test: testTornadoMathRadians     ................  [PASS] 
	Running test: testTornadoMathRadiansDouble ................  [PASS] 
	Running test: testMathATan2              ................  [PASS] 
	Running test: testMathATan2Double        ................  [PASS] 
	Running test: testMathAcos               ................  [PASS] 
	Running test: testMathASin               ................  [PASS]

mairooni
mairooni approved these changes Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@mairooni mairooni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

stratika
stratika reviewed Jul 4, 2024
View reviewed changes
...ittests/src/main/java/uk/ac/manchester/tornado/unittests/math/TestTornadoMathCollection.java Outdated
DoubleArray seq = new DoubleArray(size);

IntStream.range(0, size).parallel().forEach(i -> {
data.set(i, (float) Math.random());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess remove the casting, similar to the previous line (314).

stratika
stratika approved these changes Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@stratika stratika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment from my side.

@jjfumero jjfumero merged commit 1ea98b4 into beehive-lab:develop Jul 4, 2024
2 checks passed
@jjfumero jjfumero deleted the fix/math/api branch July 4, 2024 10:15
jjfumero added a commit to jjfumero/TornadoVM that referenced this pull request Aug 30, 2024
@jjfumero
[release] TornadoVM 1.0.7
85c1bab 
Improvements
~~~~~~~~~~~~~~~~~~

- beehive-lab#468: Cleanup Abstract Metadata Class.
- beehive-lab#473: Add maven plugin to build TornadoVM source for the releases.
- beehive-lab#474: Refactor `<X>TornadoDevice` to place common methods in the `TornadoXPUInterface`.
- beehive-lab#482: Help messages improve when an out-of-memory exception is raised.
- beehive-lab#484: Double-type for the trigonometric functions added in the `TornadoMath` class.
- beehive-lab#487: Prebuilt API simplified.
- beehive-lab#494: Add test to trigger unsupported features related to direct use of Memory Segments.
- beehive-lab#509: Add a quick pass configuration to skip the heavy tests during active development.
- beehive-lab#532: Improve thread scheduler to support RISC-V Accelerators from Codeplay.
- beehive-lab#533: Support for scalar values to be passed via lambda expressions as tasks.
- beehive-lab#538: `README` file updated.
- beehive-lab#539: Refactor core classes and add new API methods to pass compilation flags to the low-level driver compilers (OpenCL, PTX and Level Zero).
- beehive-lab#542: Tagged LevelZero JNI and Beehive Toolkit dependencies added in the build and installer.

Compatibility
~~~~~~~~~~~~~~~~~~

- beehive-lab#465: Support for JDK 22 and GraalVM 24.0.2.
- beehive-lab#486: Temurin for Windows added in the list of supported JDKs.
- beehive-lab#525: Revert usage of String Templates in preparation for JDK 23.
- beehive-lab#527: SPIR-V version parameter added. TornadoVM may run previous SPIR-V versions (e.g., ComputeAorta from Codeplay).
- beehive-lab#513: LevelZero JNI Library updated to v0.1.4.

Bug Fixes
~~~~~~~~~~~~~~~~~~

- beehive-lab#470: README documentation fixed.
- beehive-lab#478: Fix the test names that are present in the white list.
- beehive-lab#488: FP64 Kind for radian operations and the PTX backend fixed.
- beehive-lab#493: Tests Whitelist for PTX backend fixed.
- beehive-lab#502: Fix barrier type in the documentation regarding programmability of reductions.
- beehive-lab#514: Installer script fixed.
- beehive-lab#540: Fix  issue with clean-up execution IDs function.
- beehive-lab#541: Fix Data Accessors for the prebuilt API.
- beehive-lab#543: Fix checkstyle condition and FP16 error message improved.
@jjfumero jjfumero mentioned this pull request Aug 30, 2024
Merged
jjfumero added a commit to jjfumero/TornadoVM that referenced this pull request Aug 30, 2024
@jjfumero
[release] TornadoVM 1.0.7
035cfbc 
Improvements
~~~~~~~~~~~~~~~~~~

- beehive-lab#468: Cleanup Abstract Metadata Class.
- beehive-lab#473: Add maven plugin to build TornadoVM source for the releases.
- beehive-lab#474: Refactor `<X>TornadoDevice` to place common methods in the `TornadoXPUInterface`.
- beehive-lab#482: Help messages improved when an out-of-memory exception is raised.
- beehive-lab#484: Double-type for the trigonometric functions added in the `TornadoMath` class.
- beehive-lab#487: Prebuilt API simplified.
- beehive-lab#494: Add test to trigger unsupported features related to direct use of Memory Segments.
- beehive-lab#509: Add a quick pass configuration to skip the heavy tests during active development.
- beehive-lab#532: Improve thread scheduler to support RISC-V Accelerators from Codeplay.
- beehive-lab#533: Support for scalar values to be passed via lambda expressions as tasks.
- beehive-lab#538: `README` file updated.
- beehive-lab#539: Refactor core classes and add new API methods to pass compilation flags to the low-level driver compilers (OpenCL, PTX and Level Zero).
- beehive-lab#542: Tagged LevelZero JNI and Beehive Toolkit dependencies added in the build and installer.

Compatibility
~~~~~~~~~~~~~~~~~~

- beehive-lab#465: Support for JDK 22 and GraalVM 24.0.2.
- beehive-lab#486: Temurin for Windows added in the list of supported JDKs.
- beehive-lab#525: Revert usage of String Templates in preparation for JDK 23.
- beehive-lab#527: SPIR-V version parameter added. TornadoVM may run previous SPIR-V versions (e.g., ComputeAorta from Codeplay).
- beehive-lab#513: LevelZero JNI Library updated to v0.1.4.

Bug Fixes
~~~~~~~~~~~~~~~~~~

- beehive-lab#470: README documentation fixed.
- beehive-lab#478: Fix the test names that are present in the white list.
- beehive-lab#488: FP64 Kind for radian operations and the PTX backend fixed.
- beehive-lab#493: Tests Whitelist for PTX backend fixed.
- beehive-lab#502: Fix barrier type in the documentation regarding programmability of reductions.
- beehive-lab#514: Installer script fixed.
- beehive-lab#540: Fix  issue with clean-up execution IDs function.
- beehive-lab#541: Fix Data Accessors for the prebuilt API.
- beehive-lab#543: Fix checkstyle condition and FP16 error message improved.

minor change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratika stratika stratika approved these changes

@mairooni mairooni mairooni approved these changes

Assignees

@jjfumero jjfumero

Labels
API
Projects
TornadoVM 1.X (Public)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjfumero @mairooni @stratika