Don't decode CSV results

Fixes #53
beardon · Dec 19, 2016 · 200e84c · 200e84c · dciccale · Dec 19, 2016
1 parent 36bb0e3
commit 200e84c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 11 deletions.
diff --git a/lib/client.js b/lib/client.js
@@ -8,7 +8,6 @@ const request = require('request');
 const tls = require('tls');
 const parser = require('xml2json');
 const Type = require('./types');
-const iconv = require('iconv-lite');
 
 Promise.promisifyAll(request);
 
@@ -22,10 +21,6 @@ function getMetadata(data) {
     return data[_.keys(data)[0]].ResponseMetadata;
 }
 
-function hasNext(result) {
-
-}
-
 class AmazonMwsClient {
     /**
      * Constructor for the main MWS client interface used to make api calls and
@@ -47,7 +42,8 @@ class AmazonMwsClient {
                 max_backoff: 10000,
                 max_attempts: Infinity,
                 attempt: -1,
-                contentType: 'application/x-www-form-urlencoded'
+                contentType: 'application/x-www-form-urlencoded',
+                parseCSVResult: (data) => Promise.resolve(data)
             }
         });
 
@@ -135,10 +131,7 @@ class AmazonMwsClient {
             const body = response.body;
 
             if (body.slice(0, 5) !== '<?xml') {
-                const result = iconv.decode(new Buffer(body), 'iso-8859-1');
-                const metadata = null;
-
-                return { result, metadata };
+                return meta.parseCSVResult(result).then((result) => ({ result, metadata: null }));
             }
 
             const data = JSON.parse(parser.toJson(body));

diff --git a/package.json b/package.json
@@ -28,7 +28,6 @@
   },
   "dependencies": {
     "bluebird": "^3.4.4",
-    "iconv-lite": "^0.4.13",
     "lodash": "^4.17.0",
     "request": "^2.79.0",
     "xml": "^1.0.1",