Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

23 create events and tickets #24

Merged
merged 9 commits into from
Oct 11, 2023
Merged

Conversation

lgmfred
Copy link
Collaborator

@lgmfred lgmfred commented Oct 6, 2023

Hey folks,

@MICHAELMUNAVU83 There's really nothing in this PR yet (well, besides a sad attempt at the Events LiveView templates). I'm trying to play around with the events and tickets relationship defined(#23) but I've to admit we didn't do much in the DB design session we had.

image

This is the only thing we came up with about events and tickets. Did we mean to define a ticket here or a ticket type for an event?

I believe each event is supposed to define its own ticket type and prices, or are we going to assume all events will have the same ticket types?

Also, how best can we define the relationship between an event and its ticket types in the DB? Will ticket types and prices be stored in a field on the event table or in a different table(s)? If in a field, in which format?

Sorry, my SQL knowledge is very minimal and clarification on this would make this just a bit simpler. Thanks

@lgmfred lgmfred linked an issue Oct 6, 2023 that may be closed by this pull request
@lgmfred lgmfred force-pushed the 23-create-events-and-tickets branch from 9014eec to 3e3712d Compare October 10, 2023 19:37
@lgmfred lgmfred marked this pull request as ready for review October 10, 2023 19:42
Copy link
Collaborator

@MICHAELMUNAVU83 MICHAELMUNAVU83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lgmfred , Nice work , I have left a review , all that is required is for you to add a column to the ticket_types table called number .

lib/elixir_conf_africa/ticket_types/ticket_type.ex Outdated Show resolved Hide resolved
Copy link
Collaborator

@MICHAELMUNAVU83 MICHAELMUNAVU83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @lgmfred , this has been approved

@MICHAELMUNAVU83 MICHAELMUNAVU83 merged commit d011a1e into main Oct 11, 2023
2 checks passed
@lgmfred lgmfred deleted the 23-create-events-and-tickets branch October 11, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create events and tickets
2 participants