Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: add Beam community common config #721

Merged
merged 4 commits into from
Nov 10, 2024

Conversation

jsegal205
Copy link
Contributor

@jsegal205 jsegal205 requested a review from a team as a code owner November 1, 2024 16:42
Comment on lines +37 to +40
- name: Setup Elixir
uses: stordco/actions-elixir/setup@v1
with:
github-token: ${{ secrets.GH_PERSONAL_ACCESS_TOKEN }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't specify the elixir and erlang versions here. By default this action will read from the .tool-versions file and this repo uses differ node, elixir and erlang version than what is noted in common-config repo file.

@btkostner is there some documentation we can / should add to the common-config repo for how to override this file so it doesn't get lost with the periodic syncs? Or is the comment at the top of this file a bit of a scare tactic?

Copy link
Member

@btkostner btkostner Nov 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is kinda intentional because we might need to load dependencies and changing versions can break that. With that said, it's not a great solution because it also means we don't know what elixir version our common-config scripts will run against.

Also this file will get overwritten on every common-config run, so no custom edits are allowed.

@doomspork doomspork added this pull request to the merge queue Nov 10, 2024
Merged via the queue into main with commit 525b239 Nov 10, 2024
6 checks passed
@doomspork doomspork deleted the beam-community-common-config branch November 10, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants