-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Use cloudpickle to run remote functions in jupyter environments #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dleviminzi
commented
Jan 14, 2025
luke-lombardi
requested changes
Jan 15, 2025
luke-lombardi
requested changes
Jan 17, 2025
luke-lombardi
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve BE-2218
This PR changes the strategy used for running remote functions in notebooks. Instead of creating a temporary file built by stitching together executed cells, we use cloudpickle to capture the required function + deps. This resolves issues with re-executed cells and is generally more reliable.
This PR also changes the way that the default python environment is selected for
Image
. It tries to see if the active python version from the local environment is a valid remote python version. If it is, it will use that version by default. I can remove this change or limit it to ipython environments only. This is nice when working in jupyter notebooks because cloudpickle dumps are dependent on the python version. If you create a dump in 3.12 and try to load it in 3.10, things will not work.TODO: