Feat: Add min_containers to QueueDepthAutoscaler and instance controller for loading and reloading instances #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsun-m
changed the title
luke-lombardi
requested changes
Jan 13, 2025
luke-lombardi
requested changes
Jan 14, 2025
luke-lombardi
requested changes
Jan 15, 2025
jsun-m
changed the title
|
For the refactored portion of the controllers. I added a new controller called |
luke-lombardi
requested changes
Jan 17, 2025
pkg/abstractions/common/instance.go
Outdated
| } | ||
|
|
||
| func (ic *InstanceController) reload(stubId, stubType string) error { | ||
| if stubType != types.StubTypeEndpointDeployment && stubType != types.StubTypeASGIDeployment { |
There was a problem hiding this comment.
can you remind me why we have this check? isn't this used for taskqueues as well?
There was a problem hiding this comment.
this is wrong. I didnt remove this piece of code when consolidating the logic.
| endpointInstances *common.SafeMap[*endpointInstance] | ||
| tailscale *network.Tailscale | ||
| taskDispatcher *task.Dispatcher | ||
| instanceController *abstractions.InstanceController |
There was a problem hiding this comment.
can we just call it controller?
| }}, | ||
| ) | ||
| go eventBus.ReceiveEvents(ctx) | ||
| es.instanceController = abstractions.NewInstanceController(ctx, es.InstanceFactory, []string{types.StubTypeEndpointDeployment, types.StubTypeASGIDeployment}, es.backendRepo, es.rdb) |
There was a problem hiding this comment.
same comment as above
| queueClient *taskQueueClient | ||
| tailscale *network.Tailscale | ||
| eventRepo repository.EventRepository | ||
| instanceController *abstractions.InstanceController |
luke-lombardi
requested changes
Jan 17, 2025
| stubId := e.Args["stub_id"].(string) | ||
| stubType := e.Args["stub_type"].(string) | ||
|
|
||
| if stubType != types.StubTypeTaskQueueDeployment { |
There was a problem hiding this comment.
@jsun-m the place where you're doing the correctStub check, you need to return true I think or else it will resend the event
luke-lombardi
deleted the
john/be-2200-add-min_containers-to-queuedepthautoscaler
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add min_containers field that allows users to set a the minimum amount of containers to keep warm when there is no activity.
Follow up: