Fix: Stuck build containers #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luke-lombardi
requested changes
Jan 10, 2025
luke-lombardi
requested changes
Jan 10, 2025
jsun-m
requested changes
Jan 13, 2025
jsun-m
approved these changes
Jan 14, 2025
luke-lombardi
requested changes
Jan 17, 2025
luke-lombardi
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve BE-2203
This PR contains to work to fix one of the likely causes of stuck build workers. Basically, if a user cancels a build (Ctrl-C) before the build container has started, the worker will get stuck. As things are, the entire build will carry on as if nothing happened and then the container will just sit there forever.
To prevent this from happening we can use redis pub/sub. When the context is cancelled in the gateway, we publish a stop-build event to a channel containing the container id (
stop-build-{container_id}). Meanwhile, when the worker claims the container request, it subscribes to that same channel. If an event comes through it cancels the context that has been passed down.