Feat: Detect and log OOM kills in container logs #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luke-lombardi
requested changes
Oct 25, 2024
nickpetrovic
force-pushed
the
np/detect-oom-kills
branch
2 times, most recently
from
2e11578
to
3380ca3
Compare
luke-lombardi
requested changes
Oct 30, 2024
- Add Pod UID to pod environment - Move capturing of container pid to spawn function - Start goroutine of watching for oom kills right after runc pid created Resolve BE-1972
- Move container structs to lifecycle.go - Use cgroups package to detect cgroup version and read memory events - Set cgroup path on runc container spec - Send oom message to output chan - Remove POD_UID env var - Move delete container instance from processStopContainerEvents to stopContainer and only delete if kill=true - Move "container still running" log message after detecting for orphaned container
nickpetrovic
force-pushed
the
np/detect-oom-kills
branch
from
b43dbd3
to
5026e62
Compare
luke-lombardi
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve BE-1972