Skip to content

Commit

Permalink
Fix: Remove instance spec from exec env (#802)
Browse files Browse the repository at this point in the history
For some reason this was causing our base requirement installation to
fail. I suspect it might have been duplicating some of the env vars from
the base spec, which might have been causing issues. We should
investigate adding the vars not already included and see if that still
causes issues. For now, this seems to fix the problem.
  • Loading branch information
dleviminzi authored Dec 20, 2024
1 parent bb94191 commit 7fae1dd
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion pkg/worker/runc_server.go
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@ func (s *RunCServer) RunCExec(ctx context.Context, in *pb.RunCExecRequest) (*pb.
if !exists {
return &pb.RunCExecResponse{Ok: false}, nil
}
process.Env = append(process.Env, instance.Spec.Process.Env...)
if instance.Request.IsBuildRequest() {
process.Env = append(process.Env, instance.Request.BuildOptions.BuildSecrets...)
}
Expand Down

0 comments on commit 7fae1dd

Please sign in to comment.