log retry failures (#804)

beam-cloud · Dec 20, 2024 · 09688e6 · 09688e6
1 parent 906525a
commit 09688e6
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/pkg/task/dispatch.go b/pkg/task/dispatch.go
@@ -205,11 +205,7 @@ func (d *Dispatcher) RetryTask(ctx context.Context, task types.TaskInterface) er
 
 	// Hit retry limit, cancel task and resolve
 	if taskMessage.Retries >= taskMessage.Policy.MaxRetries {
-
-		// Don't bother logging it if the retry limit is set to 0, it's just noise
-		if taskMessage.Policy.MaxRetries != 0 {
-			log.Info().Str("task_id", taskMessage.TaskId).Str("stub_id", taskMessage.StubId).Msg("dispatcher hit retry limit, not reinserting task")
-		}
+		log.Info().Str("task_id", taskMessage.TaskId).Str("stub_id", taskMessage.StubId).Msg("dispatcher hit retry limit, not reinserting task")
 
 		err = task.Cancel(ctx, types.TaskExceededRetryLimit)
 		if err != nil {