Remove cgi dependency from Client #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdujava
force-pushed
the
remove_cgi
branch
2 times, most recently
from
d0c1d24 to
7cc9447
Compare
p3ck
reviewed
Dec 24, 2023
mdujava
force-pushed
the
remove_cgi
branch
3 times, most recently
from
340dc5b to
0eb25e4
Compare
mdujava
force-pushed
the
remove_cgi
branch
2 times, most recently
from
13d452a to
0eb25e4
Compare
|
Problem is when defining subclass like But this is not problem with the removal of the cgi dependency. Not sure why MR introducing github action did pass. |
This is the first reference to the Python 3 codebase (common->client). All other uses of bkr.common.helpers were in labcontroller and server. This is why we never caught this problem. |
Common/bkr/common/helpers.py
Outdated
| @@ -100,7 +101,8 @@ def run(self): | |||
| self.finished.clear() | |||
|
|
|||
|
|
|||
| class SensitiveUnicode(unicode): | |||
| @python_2_unicode_compatible | |||
| class SensitiveUnicode(): | |||
There was a problem hiding this comment.
Should this be derived from str ?
Suggested change
| class SensitiveUnicode(): | |
| class SensitiveUnicode(str): |
There was a problem hiding this comment.
Actually that doesn't change the error
There was a problem hiding this comment.
Did not find a way how to make it compatible, so I put it into separate file for now.
mdujava
force-pushed
the
remove_cgi
branch
3 times, most recently
from
759e682 to
54836eb
Compare
|
/packit build |
StykMartin
reviewed
Dec 31, 2023
StykMartin
approved these changes
Dec 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.