Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow a delpy before and after message is send #33

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

JumpLink
Copy link
Collaborator

@JumpLink JumpLink commented Apr 2, 2024

This is part of the user feedback, after the thank you message is rendered, a delay should be added before the next callouts are listed.

Changes

  • New Renderer properties afterDelay and beforeDelay for a delay after and before the message is sent
  • Wait 3000 milliseconds after the thank you message (and before the list callout message) is send
  • Update beabee-common and corresponding changes to the interface names
  • Some cleanups

@JumpLink JumpLink requested a review from rlafuente April 2, 2024 13:39
@rlafuente
Copy link
Contributor

looks good -- 3 sec sounds like a reasonable amount, but user testing will tell :-) regarding the code I don't have useful input here. Good one!

@JumpLink JumpLink merged commit 66d3674 into main Apr 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants