Fix the Issues #43 #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdarnell
reviewed
Aug 27, 2017
| FIELD_TYPE = MySQLdb.constants.FIELD_TYPE | ||
| FLAG = MySQLdb.constants.FLAG | ||
| CONVERSIONS = copy.copy(MySQLdb.converters.conversions) | ||
| if MySQLdb.__package__ != 'pymysql': |
There was a problem hiding this comment.
MySQLdb may be None (see the comments above about readthedocs). There is no guarantee that the __package__ attribute is present. I think it's better to set a variable in the import block at the top to say which module is in use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.