set defaults for settings, and respect max_frame_size in sending

responses to clients
bdarnell · Feb 21, 2019 · e0dd9ae · e0dd9ae
1 parent 3271f02
commit e0dd9ae
Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/tornado_http2/connection.py b/tornado_http2/connection.py
@@ -34,7 +34,8 @@ def __init__(self, stream, is_client, params=None, context=None):
         self.context = context
         self._initial_settings_written = Future()
         self._serving_future = None
-        self._settings = {}
+        self._settings = {setting.code : setting.default for setting in
+                constants.Setting}
 
         self.streams = {}
         self.next_stream_id = 1 if is_client else 2

diff --git a/tornado_http2/stream.py b/tornado_http2/stream.py
@@ -323,7 +323,9 @@ def _write_chunk(self, chunk, callback=None):
             if chunk:
                 yield self.write_lock.acquire()
                 while chunk:
-                    allowance = yield self.window.consume(len(chunk))
+                    bytes_to_write = min(len(chunk), self.conn.setting(
+                        constants.Setting.MAX_FRAME_SIZE))
+                    allowance = yield self.window.consume(bytes_to_write)
 
                     yield self.conn._write_frame(
                         Frame(constants.FrameType.DATA, 0,