Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cran fixes #98

Merged
merged 10 commits into from
Oct 18, 2024
Merged

cran fixes #98

merged 10 commits into from
Oct 18, 2024

Conversation

bczernecki
Copy link
Owner

Addressing issues found during latest CRAN submission

@bczernecki bczernecki self-assigned this Oct 16, 2024
@bczernecki bczernecki linked an issue Oct 16, 2024 that may be closed by this pull request
Repository owner deleted a comment from codecov bot Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 6 lines in your changes missing coverage. Please review.

Project coverage is 83.71%. Comparing base (a00fa13) to head (6ec6fd3).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
R/hydro_imgw_daily.R 50.00% 1 Missing ⚠️
R/hydro_imgw_monthly.R 0.00% 1 Missing ⚠️
R/meteo_noaa_co2.R 0.00% 1 Missing ⚠️
R/nearest_stations_ogimet.R 0.00% 1 Missing ⚠️
R/ogimet_hourly.R 50.00% 1 Missing ⚠️
R/stations_ogimet.R 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
+ Coverage   82.80%   83.71%   +0.91%     
==========================================
  Files          32       32              
  Lines        1756     1750       -6     
==========================================
+ Hits         1454     1465      +11     
+ Misses        302      285      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nowosad
Copy link
Collaborator

Nowosad commented Oct 18, 2024

Two examples failed when no internet was available: I removed/commented them out.

@bczernecki bczernecki merged commit 68af360 into master Oct 18, 2024
11 checks passed
@bczernecki bczernecki deleted the 90-cran-fixes branch October 20, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why not on CRAN anymore?
2 participants